diff options
| author | ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> | 2024-08-26 15:11:41 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-26 12:11:41 -0700 |
| commit | e1c6fecd90142761aaecbf4e281beb87893fc531 (patch) | |
| tree | 30cf06cf6a7ea4a55b2d3e4ecd5d4f13f1f31e60 /source/slang/slang-ir-lower-buffer-element-type.cpp | |
| parent | 76999788902a8c50e8e5d0e867763e5ea2f10042 (diff) | |
Implement `-fvk-use-dx-layout` (#4912)
* Implement `-fvk-use-dx-layout`
Fixes: #4126
Changes:
* Added fvk-use-dx-layout
* Modified `HLSLConstantBufferLayoutRulesImpl` for correctness (ex: Array is always 16 byte aligned)
* Added kFXCShaderResourceLayoutRulesFamilyImpl and kFXCConstantBufferLayoutRulesFamilyImpl to handle fvk-use-dx-layout
* Added `ConstantBufferLayoutRules` to manage constant buffer rules
* Added `alignCompositeElementOfNonAggregate`/`alignCompositeElementOfAggregate` to handle forced alignment of composites for ConstantBuffers
* `StructuredBuffer` rules are mostly equal to `scalar` layout, not much was needed to be changed to support this behavior.
* seperate legacy constant buffer and how Slang does constant-buffer normally
* undo an addition
* remove accidental test
* Address review and fix
Address review and remove GLSL support since GLSL requires a seperate legalization (need to linearlize structs like with `legalizeMetalIR` to assign explicit offsets)
* comments
* remove aggregate and non-aggregate logic
We don't need this distinction for the logic
---------
Co-authored-by: Yong He <yonghe@outlook.com>
Diffstat (limited to 'source/slang/slang-ir-lower-buffer-element-type.cpp')
| -rw-r--r-- | source/slang/slang-ir-lower-buffer-element-type.cpp | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/source/slang/slang-ir-lower-buffer-element-type.cpp b/source/slang/slang-ir-lower-buffer-element-type.cpp index cc24a0e81..a480ae673 100644 --- a/source/slang/slang-ir-lower-buffer-element-type.cpp +++ b/source/slang/slang-ir-lower-buffer-element-type.cpp @@ -899,6 +899,16 @@ namespace Slang if (target->getOptionSet().shouldUseScalarLayout()) return IRTypeLayoutRules::getNatural(); + if (target->getOptionSet().shouldUseDXLayout()) + { + if (as<IRUniformParameterGroupType>(bufferType)) + { + return IRTypeLayoutRules::getConstantBuffer(); + } + else + return IRTypeLayoutRules::getNatural(); + } + // The default behavior is to use std140 for constant buffers and std430 for other buffers. switch (bufferType->getOp()) { |
