diff options
| author | Yong He <yonghe@outlook.com> | 2023-04-27 17:00:37 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-27 17:00:37 -0700 |
| commit | 60d829091cc97eef4fd36211afe8a83ad282c4de (patch) | |
| tree | 1eff59d3a39feba0408b89406da28fa35d1567d4 /source/slang/slang-ir-autodiff.cpp | |
| parent | d1cc6a8c1e5b378ea34dc4006045bcbd37e0dfd3 (diff) | |
Small fixes to autodiff pass. (#2852)
* Remove obsolete assert in `extractPriamlFunc`.
* Fix `findUniqueStoredVal` to ignore diff uses.
---------
Co-authored-by: Yong He <yhe@nvidia.com>
Diffstat (limited to 'source/slang/slang-ir-autodiff.cpp')
| -rw-r--r-- | source/slang/slang-ir-autodiff.cpp | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/source/slang/slang-ir-autodiff.cpp b/source/slang/slang-ir-autodiff.cpp index 4889558a5..62cb0b841 100644 --- a/source/slang/slang-ir-autodiff.cpp +++ b/source/slang/slang-ir-autodiff.cpp @@ -1858,6 +1858,9 @@ IRUse* findUniqueStoredVal(IRVar* var) { if (const auto callInst = as<IRCall>(use->getUser())) { + // Ignore uses from differential blocks. + if (callInst->getParent()->findDecoration<IRDifferentialInstDecoration>()) + continue; // Should not see more than one IRCall. If we do // we'll need to pick the primal call. // @@ -1874,6 +1877,9 @@ IRUse* findUniqueStoredVal(IRVar* var) { if (const auto storeInst = as<IRStore>(use->getUser())) { + // Ignore uses from differential blocks. + if (storeInst->getParent()->findDecoration<IRDifferentialInstDecoration>()) + continue; // Should not see more than one IRStore SLANG_RELEASE_ASSERT(!storeUse); storeUse = use; @@ -1890,15 +1896,18 @@ IRUse* findUniqueStoredVal(IRVar* var) IRUse* findLatestUniqueWriteUse(IRVar* var) { IRUse* storeUse = nullptr; - // If no unique store found, try to look for a call. for (auto use = var->firstUse; use; use = use->nextUse) { if (const auto callInst = as<IRCall>(use->getUser())) { + // Ignore uses from differential blocks. + if (callInst->getParent()->findDecoration<IRDifferentialInstDecoration>()) + continue; SLANG_RELEASE_ASSERT(!storeUse); storeUse = use; } } + // If no unique call found, try to look for a store. return findUniqueStoredVal(var); } @@ -1917,6 +1926,9 @@ IRUse* findEarliestUniqueWriteUse(IRVar* var) { if (const auto callInst = as<IRCall>(use->getUser())) { + // Ignore uses from differential blocks. + if (callInst->getParent()->findDecoration<IRDifferentialInstDecoration>()) + continue; SLANG_RELEASE_ASSERT(!storeUse); storeUse = use; } |
