Reverse-mode AD fixes for loops with non-trivial break region (#2671)

* Fix crash when applying autodiff to functions with no arguments

* Fixes for loops where the break region is non-trivial

* Minor fix

* Implement array legalization correctly.

* Fix array legalization.

---------

Co-authored-by: Yong He <yhe@nvidia.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/source/slang/slang-ir-autodiff-rev.cpp b/source/slang/slang-ir-autodiff-rev.cpp
index 55c0ee46d..640f516ed 100644
--- a/source/slang/slang-ir-autodiff-rev.cpp
+++ b/source/slang/slang-ir-autodiff-rev.cpp
@@ -568,11 +568,9 @@ namespace Slang
     {
         DifferentiableTypeConformanceContext* diffTypeContext;
 
-        virtual bool shouldConvertAddrInst(IRInst* addrInst) override
+        virtual bool shouldConvertAddrInst(IRInst*) override
         {
-            if (isDifferentiableType(*diffTypeContext, addrInst->getDataType()))
-                return true;
-            return false;
+            return true;
         }
     };
 
@@ -598,7 +596,9 @@ namespace Slang
 
         if (SLANG_SUCCEEDED(result))
         {
+            disableIRValidationAtInsert();
             simplifyFunc(func);
+            enableIRValidationAtInsert();
         }
         return result;
     }