summaryrefslogtreecommitdiff
path: root/source/slang/slang-emit-spirv.cpp
diff options
context:
space:
mode:
authorJerran Schmidt <jerrans@nvidia.com>2025-06-27 02:33:16 +1000
committerGitHub <noreply@github.com>2025-06-26 16:33:16 +0000
commit83c7b7c7716c31596d9e2829d4afa708ce23a182 (patch)
treef2a152b41273399e015d476aaca60278fa10928c /source/slang/slang-emit-spirv.cpp
parentbf94fc3f5b73033334db28846580f16df42d6a85 (diff)
Fix for OpUConvert producing invalid opcode when to/from signs differ (#7398)
* Fix for OpUConvert outputting scalar type for mixed sign vector type conversions * Fix compiler warning * Added regression test for UConvert vector fix * Formatting * getUnsignedType helper * Formatting * Fix for addtional int types * Helper function to convert signed type to unsigned type
Diffstat (limited to 'source/slang/slang-emit-spirv.cpp')
-rw-r--r--source/slang/slang-emit-spirv.cpp8
1 files changed, 3 insertions, 5 deletions
diff --git a/source/slang/slang-emit-spirv.cpp b/source/slang/slang-emit-spirv.cpp
index 7bd20649b..82fb39d7d 100644
--- a/source/slang/slang-emit-spirv.cpp
+++ b/source/slang/slang-emit-spirv.cpp
@@ -7319,11 +7319,9 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex
// Perform unsigned conversion first to an unsigned integer of the same width as the
// result then perform bit cast to the signed result type. This is done because SPIRV's
// unsigned conversion (`OpUConvert`) requires result type to be unsigned.
- auto unsignedV = emitOpUConvert(
- parent,
- nullptr,
- builder.getType(getOppositeSignIntTypeOp(toType->getOp())),
- inst->getOperand(0));
+ auto builderType = getUnsignedTypeFromSignedType(&builder, toTypeV);
+
+ auto unsignedV = emitOpUConvert(parent, nullptr, builderType, inst->getOperand(0));
return emitOpBitcast(parent, inst, toTypeV, unsignedV);
}
else if (fromInfo.isSigned)