ASTNodes use MemoryArena (#1376)

* Add a ASTBuilder to a Module
Only construct on valid ASTBuilder (was being called on nullptr on occassion)

* Add nodes to ASTBuilder.

* Compiles with RefPtr removed from AST node types.

* Initialize all AST node pointer variables in headers to nullptr;

* Initialize AST node variables as nullptr.
Make ASTBuilder keep a ref on node types.
Make SyntaxParseCallback returns a NodeBase

* Don't release canonicalType on dtor (managed by ASTBuilder).

* Give ASTBuilders a name and id, to help in debugging.
For now destroy the session TypeCache, to stop it holding things released when the compile request destroys ASTBuilders.

* Moved the TypeCheckingCache over to Linkage from Session.

* NodeBase no longer derived from RefObject.

* Only add/dtor nodes that need destruction.
First pass compile on linux.

1 files changed, 0 insertions, 13 deletions

diff --git a/source/slang/slang-check.cpp b/source/slang/slang-check.cpp
index 5b2b2b132..b86d90cec 100644
--- a/source/slang/slang-check.cpp
+++ b/source/slang/slang-check.cpp
@@ -196,19 +196,6 @@ namespace Slang
         return func;
     }
 
-    TypeCheckingCache* Session::getTypeCheckingCache()
-    {
-        if (!typeCheckingCache)
-            typeCheckingCache = new TypeCheckingCache();
-        return typeCheckingCache;
-    }
-
-    void Session::destroyTypeCheckingCache()
-    {
-        delete typeCheckingCache;
-        typeCheckingCache = nullptr;
-    }
-
     void checkTranslationUnit(
         TranslationUnitRequest* translationUnit)
     {