diff options
| author | jsmall-nvidia <jsmall@nvidia.com> | 2020-02-11 16:16:43 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-11 16:16:43 -0500 |
| commit | 9b3e768bceae562deeb330067f3ef5febc2e5244 (patch) | |
| tree | 9282a68c9696f3bb0863b8e9a0474dd523edc788 /source/slang/slang-check-overload.cpp | |
| parent | 30d0932add53a50a80f07ce28576bd779b82b4c1 (diff) | |
Small improvements around List (#1216)
* * Improved fastRemoveAt
* Fixed off by one bug
* Fixed const safeness with List<>
* Made List begin and end const safe.
* Revert to previous RefPtr usage.
* Fix bug with casting.
* Tabs -> spaces.
Small fixes/improvements to List.
* Improve comment on List.
* hasContent -> isNonEmpty
Diffstat (limited to 'source/slang/slang-check-overload.cpp')
| -rw-r--r-- | source/slang/slang-check-overload.cpp | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/source/slang/slang-check-overload.cpp b/source/slang/slang-check-overload.cpp index dc013b781..20d1af09a 100644 --- a/source/slang/slang-check-overload.cpp +++ b/source/slang/slang-check-overload.cpp @@ -440,11 +440,8 @@ namespace Slang // A call may yield an l-value, and we should take a look at the candidate to be sure if(auto subscriptDeclRef = candidate.item.declRef.as<SubscriptDecl>()) { - for(auto setter : subscriptDeclRef.getDecl()->getMembersOfType<SetterDecl>()) - { - callExpr->type.IsLeftValue = true; - } - for(auto refAccessor : subscriptDeclRef.getDecl()->getMembersOfType<RefAccessorDecl>()) + const auto& decl = subscriptDeclRef.getDecl(); + if (decl->getMembersOfType<SetterDecl>().isNonEmpty() || decl->getMembersOfType<RefAccessorDecl>().isNonEmpty()) { callExpr->type.IsLeftValue = true; } |