Fix type checking & loop value hoisting (#2907)

* Fix type checking crash in language server.

* Fix loop var hoisting logic.

Fixes #2903.

* fix.

---------

Co-authored-by: Yong He <yhe@nvidia.com>

1 files changed, 9 insertions, 4 deletions

diff --git a/source/slang/slang-check-overload.cpp b/source/slang/slang-check-overload.cpp
index 4bd8506ed..0d10b05be 100644
--- a/source/slang/slang-check-overload.cpp
+++ b/source/slang/slang-check-overload.cpp
@@ -409,11 +409,12 @@ namespace Slang
             auto& arg = context.getArg(ii);
             auto argType = context.getArgType(ii);
             auto paramType = paramTypes[ii];
-
+            if (!paramType)
+                return false;
+            if (!argType)
+                return false;
             if (context.mode == OverloadResolveContext::Mode::JustTrying)
             {
-                SLANG_ASSERT(argType);
-
                 ConversionCost cost = kConversionCost_None;
                 if( context.disallowNestedConversions )
                 {
@@ -1656,7 +1657,11 @@ namespace Slang
         for( UInt aa = 0; aa < argCount; ++aa )
         {
             if(aa != 0) argsListBuilder << ", ";
-            context.getArgType(aa)->toText(argsListBuilder);
+            auto argType = context.getArgType(aa);
+            if (argType)
+                context.getArgType(aa)->toText(argsListBuilder);
+            else
+                argsListBuilder << "error";
         }
         argsListBuilder << ")";
         return argsListBuilder.produceString();