summaryrefslogtreecommitdiff
path: root/source/slang/slang-check-modifier.cpp
diff options
context:
space:
mode:
authorArielG-NV <159081215+ArielG-NV@users.noreply.github.com>2024-07-02 13:35:49 -0400
committerGitHub <noreply@github.com>2024-07-02 13:35:49 -0400
commitd5d03d1510f45f5ed7864031244713d87fc82b87 (patch)
treee0391686ca3b06406e497c4e7e7f90172355e4cf /source/slang/slang-check-modifier.cpp
parentbd01bd3f4b8eecbfb924b8eb4090694e44e8166c (diff)
Emit errors when invalid capabilities are used (#4510)
* Fix invalid capabilities being allowed fixes: #4506 fixes: #4508 1. As per #4506, no longer allow invalid `[require(...)]` 2. As per #4508, no longer allow mismatch between `case` and `require` of a calling function 3. Fixes incorrect hlsl.meta capabilities 4. Added a ref to the parent function/decl for when erroring with capabilities to help debug meta.slang files for when weird source locations are generated. * rename vars and copy lambdas by value * fix some more capabilities * incorrect capabilities on a texture test * push capabilities fix note: seperated capabilities for glsl,spirv,cuda,hlsl since not all functions support all targets (source of capability error) * fix cmd line arg by using `xslang` to passthrough to slangc * let auto-infer run for certain capabilities to reduce simple mistakes --------- Co-authored-by: Jay Kwak <82421531+jkwak-work@users.noreply.github.com>
Diffstat (limited to 'source/slang/slang-check-modifier.cpp')
-rw-r--r--source/slang/slang-check-modifier.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/source/slang/slang-check-modifier.cpp b/source/slang/slang-check-modifier.cpp
index 7721fedbf..e91d2e45b 100644
--- a/source/slang/slang-check-modifier.cpp
+++ b/source/slang/slang-check-modifier.cpp
@@ -932,6 +932,8 @@ namespace Slang
}
}
requireCapAttr->capabilitySet = CapabilitySet(capabilityNames);
+ if (requireCapAttr->capabilitySet.isInvalid())
+ maybeDiagnose(getSink(), this->getOptionSet(), DiagnosticCategory::Capability, attr, Diagnostics::unexpectedCapability, attr, CapabilityName::Invalid);
}
else if (auto requirePreludeAttr = as<RequirePreludeAttribute>(attr))
{