summaryrefslogtreecommitdiffstats
path: root/source/slang/slang-check-expr.cpp
diff options
context:
space:
mode:
authorSai Praveen Bangaru <31557731+saipraveenb25@users.noreply.github.com>2024-08-27 15:00:43 -0400
committerGitHub <noreply@github.com>2024-08-27 15:00:43 -0400
commitd40c143eb4f19f1dfd0d0dcf9b718be6e495ca27 (patch)
tree733e01744dc2788107bcca4143126dc220aa10ab /source/slang/slang-check-expr.cpp
parent59c23b96b3649e77f5428c32e47b4401a802c604 (diff)
Explicitly detach derivative when forming a non-differentiable struct out of differentiable args (#4901)
* Explicitly detach derivative when forming a non-differentiable struct out of differentiable args This fixes an issue where initializer lists get optimized out and lose information about non-differentiability. There are 2 places where this could have been fixed: 1. When coercing initializer-list exprs, we can check for non-differentiable aggregate types and use a detach derivative on all the args. 2. Add an extra case in the peephole optimization step that adds detach-derivative when simplifying a make-struct of a non-differentiable type. Even though solution 2 is more elegant, this PR goes with solution 1 simply to avoid having to use a differentiable-type-conformance-context that is used in the auto-diff IR passes to check for differentiability. * Change test name + add expected vals
Diffstat (limited to 'source/slang/slang-check-expr.cpp')
-rw-r--r--source/slang/slang-check-expr.cpp7
1 files changed, 7 insertions, 0 deletions
diff --git a/source/slang/slang-check-expr.cpp b/source/slang/slang-check-expr.cpp
index 4d36299bb..3072c3257 100644
--- a/source/slang/slang-check-expr.cpp
+++ b/source/slang/slang-check-expr.cpp
@@ -3242,6 +3242,13 @@ namespace Slang
return expr;
}
+ Expr* SemanticsExprVisitor::visitDetachExpr(DetachExpr* expr)
+ {
+ expr->inner = CheckTerm(expr->inner);
+ expr->type = expr->inner->type;
+ return expr;
+ }
+
static bool _isSizeOfType(Type* type)
{