diff options
| author | kaizhangNV <149626564+kaizhangNV@users.noreply.github.com> | 2024-04-23 18:39:15 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-23 18:39:15 -0700 |
| commit | c6b9a91253bce6d450efc281b3f86617b3eef633 (patch) | |
| tree | 4cfaaf2f298611495601b6287ef2d143420cbcc6 /source/slang/slang-check-decl.cpp | |
| parent | f1de1817ca10e34ec6a844100f10f0de3340c9f2 (diff) | |
Do not diagnose error when a symbols is defined as 'extern' and 'export' (#4010)
Fix the issue (#3999).
For a function is defined as extern and export at the same time, don't
report error, we can use the 'export' function to overload the 'extern'
function.
Diffstat (limited to 'source/slang/slang-check-decl.cpp')
| -rw-r--r-- | source/slang/slang-check-decl.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp index 17551912d..cb68dced9 100644 --- a/source/slang/slang-check-decl.cpp +++ b/source/slang/slang-check-decl.cpp @@ -6944,6 +6944,13 @@ namespace Slang if (!doFunctionSignaturesMatch(newDeclRef, oldDeclRef)) return SLANG_OK; + // If the declatation is declared by 'extern', and new definition is with 'export', then + // we should let overload resolution to handle it. + if (oldDecl->hasModifier<ExternModifier>() && newDecl->hasModifier<HLSLExportModifier>()) + { + return SLANG_OK; + } + // If we get this far, then we've got two declarations in the same // scope, with the same name and signature, so they appear // to be redeclarations. |