diff options
| author | Yong He <yonghe@outlook.com> | 2025-01-15 20:43:01 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-15 20:43:01 -0800 |
| commit | 387f2be1e48a805ef0da34510a5ae0ebc0ba9c3e (patch) | |
| tree | 8769f2b809fae510cfab39ff430063978ec3abb3 /source/slang/slang-check-decl.cpp | |
| parent | 6db69eae7ecfb5111a48723d3f3c4104c7da880a (diff) | |
Inline global constants that contains opaque handles for legalization. (#6098)
* Inline global constants that contains opaque handles for legalization.
* Add diagnostics on opaque type global variables.
* Fix.
* Fix test.
Diffstat (limited to 'source/slang/slang-check-decl.cpp')
| -rw-r--r-- | source/slang/slang-check-decl.cpp | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp index 04d5b7a75..2a5b5a4e3 100644 --- a/source/slang/slang-check-decl.cpp +++ b/source/slang/slang-check-decl.cpp @@ -2392,6 +2392,18 @@ void SemanticsDeclBodyVisitor::checkVarDeclCommon(VarDeclBase* varDecl) { getSink()->diagnose(varDecl, Diagnostics::varCannotBeUnsized); } + + bool isOpaque = (((int)varTypeTags & (int)TypeTag::Opaque) != 0); + if (isOpaque && isGlobalDecl(varDecl) && !varDecl->hasModifier<ConstModifier>() && + varDecl->hasModifier<HLSLStaticModifier>()) + { + // Opaque type global variable must be const. + getSink()->diagnose(varDecl, Diagnostics::globalVarCannotHaveOpaqueType); + if (varDecl->initExpr) + getSink()->diagnose(varDecl, Diagnostics::doYouMeanStaticConst); + else + getSink()->diagnose(varDecl, Diagnostics::doYouMeanUniform); + } } if (auto elementType = getConstantBufferElementType(varDecl->getType())) |