Add support for HLSL unorm/snorm (#2095)

Read/write resource types (what D3D/HLSL often refer to as UAVs) can be broadly categorized based on whether they require an underlying format (e.g., a `DXGI_FORMAT`) for reads, or not. D3D refers to the ones that require a format as "typed" UAVs (even though a `RWStructuredBuffer<MyData>` is clearly "typed" at the HLSL level). Vulkan refers to these cases as "storage images" and "storage texel buffers."

Under the D3D model, an application does not have to specify the exact format for a formatted/"typed" UAV in order for loads to work, but it *does* need to specify if an HLSL resource with a declared `float` or vector-of-`float` element type will be backed by data with a `*_UNORM` or `*_SNORM` format. This is where the `unorm` and `snorm` type modifiers come in.

Superficially, it might seem that adding this feature to the Slang compiler is "just" a matter of adding the two modifiers, which is easily done with a pair of one-line `syntax` declarations in `core.meta.slang` plus the corresponding AST node types.

Unfortunately the superficial view misses the detail that, to date, Slang has not had any support for *type modifiers* at all, and has only supported *declaration modifiers*. The distinction has so far not mattered, even with modifiers like `const` because, e.g., the difference between a "`const` array of `float`" and an "array of `const float`" doesn't really matter.

So, adding these two modifiers required introducing a lot of infrastructure along the way. Let's walk through what needed to happen:

* As described above, the actual `syntax` was added easily in the Slang stdlib

* I added a new subclass of `Modifier` for `TypeModifier`s in the AST, and added the AST nodes for `unorm` and `snorm` as subclasses of that.

* In order to syntactically support modifiers applied to types (e.g., `unorm float`), I needed to add a `ModifiedTypeExpr` subclass of `Expr` that represents a base type expression with one or more modifiers applied

* The parser needed some subtle new logic. There are two main cases where type modifiers will come up:

    1. In contexts where we might be parsing a declaration (e.g., `const unorm float a`), we need to support a list of modifiers that might freely mix type modifiers and "declaration modifiers" which are not intended to apply to types. In this case we need to split the lis tof modifiers into the type-related ones and the declaration-related ones, and attach each subset to the appropriate place. This is very important for features like C-style pointers, where in `static const float* a;`, the `static` modifier applies to the entire declaration of `a`, but the `const` modifier *only* applies to the `float` type specifier, and *not* to the outer pointer type (the actual type of `a`).

    2. In contexts where we are not parsing a declaration (e.g., a generic type argument), we need to support a list of modifiers and appy them *all* to the type specifier being parsed, even if some of them might not be appropriate.

* While working in the parser I implemented a certain amount of unrelated cleanup for code that was using raw `Modifier*`s to represent lists of modifiers, instead of the purpose-built `Modifiers` type.

* The `_parseGenericArg` case needed specific work, because it is an important case in the grammar where we need to parse *either* a type expression or a value exprssion, but cannot easily predict which we will see. The fix implemented for now is to always try to parse modifiers and, if we see any, to assume we are in the type case. Because of the rules for how modifiers in a C-like language inhere to the type specifier (and not necessarily the entire type), we need to refactor some of the type expression parsing routines to support parsing a "suffix" of a type expression.

    * Note: I decided to be conservative and only make these changes in `_parseGenericArg` because that is place that is *needed* in order for user code with `unorm`/`snorm` to work, but in practice a user could still confuse our parser by using type modifiers as part of a cast (e.g., `x = (unorm float)y;`). While there is currently no reason why a user should want to do this, it *does* suggest that we need to be prepared to see type modifiers in other ambiguous "expression or type?" contexts. We have so far preferred to avoid looking up built-in syntax declarations like modifiers in expression contexts, because we want to allow users to create variable names that might conflict with some of the more surprising modifier keywords in HLSL (e.g., both `triangle` and `sample` are modifier keyword). A nuanced strategy may be required when we get around to closing this gap (which will be needed around when we want full pointer support, since a cast like `(const SomeType*)somePtr` is pretty common).

* In semantic checking, we now need a `visitModifiedTypeExpr`, which visits the base expression to produce a `Type` and then checks each of the `Modifier`s attached to it. During this process we need to translate the AST-level `Modifier`s into something that can exist properly in the universe of `Type`s. We introduce a `ModifiedType` subclass of `Type`, distinct from the `ModifiedTypeExpr` subclass of `Expr`. Furthermore, we introduce a `ModifierVal` subclass of `Val`, distinct from `Modifier`/`TypeModifier`.

    * One unfortunate thing here is that it means we have both, e.g., `UNormModifier` to represent the parsed syntax, and `UNormModifierVal` to represent the `Type`/`Val`-level representation of the same concept. It is quite likely that we are near the point where we can/should consider having two distinct AST representations: one for freshly-parsed ASTs and one for semantically-checked ASTs. The `Type`/`Val` hierarchy clearly belongs to the latter.

    * No actual semantic checking is currently being applied to the `unorm` and `snorm` modifiers, although we should in principle check that they are only being applied to `float` and vector-of-`float` types.

* In an attempt to simplify some of the creation logic and build a tiny bit of reusable infrastructure, I went ahead and added the skeleton of a dedupe-caching system in `ASTBuilder` so that we can easily ensure only a single `UNormModifierVal` and a single `SNormModifierVal` ever get created inside the scope of a single builder.

    * TODO: Thinking about this, I'm now worried the deduplication does not mean I can make the simplifications I currently do in semantic checking by assuming that any two `UNormModifierVal`s will be pointer-identical. This is because we do not currently (IIRC) have the required "bottleneck" in the compiler where all ASTs get serialized after initial checking, and then deserialized when `import`ed into a downstream module, so that every AST node during a checking step comes from a single `ASTBuilder`. Hmm...

* If we can rely on deduplication to do its thing, then the `Val` and `Type` implementations of modifiers can be relatively simple.

    * TODO: One issue here is that the equality comparison for `ModifiedType` currently checks for the same base type and the same modifiers in the same order. This works for now when we only have a small number of type modifiers and any given type will hae at most one, but in the longer run it relies on us to implement some kind of canonicalization scheme, which would both ensure that between `Modified(T, {A, B})` and `Modified(T, {B, A})` only one is allowed (that is, a canonical ordering on modifiers), and that we do not allow `Modified(Modified(T, {A}), {B})`.

    * TODO: One other issues is that the `ModifiedType` case does not currently interact correctly with the `as()`-based casting for types (whereas that operation *does* interact in a semantically-correct fashion with `typedef`s). Fixing this issue in a robust way really depends on us re-architecting the `Type` system so that *any* `Type` can have modifiers attached, with modifiers affecting type identity/deduplication.

* The key place where `ModifiedType` creates a complication in semantic checking is type conversion/coercion. A user is likely to declare a `RWTexture2D<unorm float>`, fetch from it (producing a value of type `unorm float`) and then assign the result to a `float` variable, prompting for a conversion from `unorm float` to `float` (because they are distinct `Type`s).

    * We handle this case in the core `_coerce()` operation by checking if either `toType` or `fromType` is a `ModifiedType`. If *either* one is a modified type, we apply logic to check for modifiers that are present on one and not the other. Basically we check which modifiers need to be "dropped" and which need to be "added" during conversion, and validate that these modifiers *can* be dropped/added without creating a semantic error. The only type modifiers we support right now *can* be dropped/added like this, so we are fine.

    * TODO: When we add more complete pointer support, we could need logic here to validate when casts between, e.g., `const int*` and `int*` should/shouldn't be allowed.

    * Note: Even opening the door to type modifiers at all creates the same kind of challenges for user-defined generic types (and functions!) since `MyType<int>` and `MyType<const int>` are distinct instantiations in a future where we support `const` as a type modifier. We *may* need to plan to restrict where modified types can be used, so that certain built-in generic types support modified types as arguments, but user-defined types don't (or at least might need to opt-in to get support).

    * The result of a `_coerce()` that drops/adds modifiers is a `ModifierCastExpr`, which is a kind of no-op AST node that merely expresses that the conversion is allowed and valid.

* In IR lowering we currently do the simple thing and translate a `ModifiedType` to a distinct IR node called `AttributedType`.

    * The change in terminology from "modifier" to "attribute" is to follow the way that these kinds of modifiers best map to the `IRAttr` case in the IR (rather than the `IRDecoration` case). We probably ought to do a careful terminology scrub here, because having this terminology mismatch between IR and AST could be a source of confusion.

    * TODO: In principle, using `IRAttributedType` creates the same basic problems as using `ModifiedType`: code that is usin `as()` or similar operations to check for a specific subclass of `IRType` may not see the case they were looking for due to use of `IRAttributedType`.

        * Initially I had hoped to avoid the problem by having the `IRAttr`s be attached directly as operands to an otherwise-ordinary `IRType`. E.g., a lowered `unorm float4` would be an `IRVectorType` with an "extra" operand that is an `IRUNormAttr`, something like: `Vector<Float, 4, UNorm>`. This sounds great (and looks great!), but runs into the problem that it is incompatible with the way we currently represent things like generic type parameters. A generic type parameter `T` is represented as an `IRParam`, and it does *not* make sense to have an additional `IRParam` to represent `const T` or `unorm T`, etc.

        * The Right Way to solve this stuff at both the AST and IR levels is to avoid passing around bare `Type*` or `IRType*` in general, and instead use a value type that implements the needed policy more directly: something like a `TypeHolder` or `IRTypeHolder` (placeholder name). The `*Holder` type would abstract over the various "wrapper" nodes required to store all the additional data like attributes but, importantly, would *not* allow that extra information to be dropped or lost during operations like casting (e.g., note how the current `Type` implementation of `as()` loses information on `typedef` names, making our error messages slightly worse). This is actually quite similar to how we currently use the `DeclRef<T>` system to allow working with what is *usually* a `T*` under the hood, but in a way that ensures we don't lose track of any generic substitution information.

* During C-like code emit we have a process that turns an `IRType` into a chain of declarators as needed to emit a C-like declaration with pointers, arrays, etc. The `IRAttributedType` case needs to get folded into this logic. Basically, when we see an `IRAttributedType` we immediately emit any modifiers that are required to be in a prefix position, then recursively emit the underlying type with an extra layer of declarator that tracks the modifiers, so that we can emit any modifiers that should be placed in a postfix position *after* the type. As a specific example, our C/C++ back-end would want to use the postifx option to handle `const`, because then it can properly emit stuff like `int const * const *` and not the incorrect `const const int**`.

* The HLSL emit logic overrides the prefix case for handling type attributes, and uses it to emit `unorm` and `snorm` where they occur.

* One unfortunate detail is that (apparently) some downstream HLSL compilers do not allow the `unorm`/`snorm` modifiers to apply to `vector<float, *>` types, even though that should be semantically valid. Instead, they only support `float`, `float2`, `float3`, and `float4` explicitly. To work around this issue, we go ahead and change our HLSL emit logic so that when we encountered 1-to-4 component vectors of `float`, `int`, or `uint` we emit the type name using the typical HLSL shorthand. This is actually a signficicant change in our HLSL output, but it both seemed like a good fix to have anyway, and was also the only obvious way to address the downstream parser shortcomings without a massive kludge.

    * As a result of this change the `half-texture.slang` test broke, since it was using raw HLSL as the expected output. I changed the test to do a DXIL comparison instead, which is our preferred way of testing cross-compilation behavior (since it is more robust in the face of small changes to our source output).

1 files changed, 145 insertions, 0 deletions

diff --git a/source/slang/slang-check-conversion.cpp b/source/slang/slang-check-conversion.cpp
index b6c7069a2..855590472 100644
--- a/source/slang/slang-check-conversion.cpp
+++ b/source/slang/slang-check-conversion.cpp
@@ -539,6 +539,68 @@ namespace Slang
         return false;
     }
 
+        /// Do the `left` and `right` modifiers represent the same thing?
+    static bool _doModifiersMatch(Val* left, Val* right)
+    {
+        if( left == right )
+            return true;
+
+        if( left->equalsVal(right) )
+            return true;
+
+        return false;
+    }
+
+        /// Does `type` have a modifier that matches `modifier`?
+    static bool _hasMatchingModifier(ModifiedType* type, Val* modifier)
+    {
+        if(!type) return false;
+
+        for( auto m : type->modifiers )
+        {
+            if(_doModifiersMatch(m, modifier))
+                return true;
+        }
+
+        return false;
+    }
+
+        /// Can `modifier` be added to a type as part of a coercion?
+        ///
+        /// For example, it is generally safe to convert from a value
+        /// of type `T` to a value of type `const T` in C/C++.
+        ///
+    static bool _canModifierBeAddedDuringCoercion(Val* modifier)
+    {
+        switch( modifier->astNodeType )
+        {
+        default:
+            return false;
+
+        case ASTNodeType::UNormModifierVal:
+        case ASTNodeType::SNormModifierVal:
+            return true;
+        }
+    }
+
+        /// Can `modifier` be dropped from a type as part of a coercion?
+        ///
+        /// For example, it is generally safe to convert from a value
+        /// of type `const T` to a value of type `T` in C/C++.
+        ///
+    static bool _canModifierBeDroppedDuringCoercion(Val* modifier)
+    {
+        switch( modifier->astNodeType )
+        {
+        default:
+            return false;
+
+        case ASTNodeType::UNormModifierVal:
+        case ASTNodeType::SNormModifierVal:
+            return true;
+        }
+    }
+
     bool SemanticsVisitor::_coerce(
         Type*    toType,
         Expr**   outToExpr,
@@ -592,6 +654,77 @@ namespace Slang
             return true;
         }
 
+        {
+            // It is possible that one or more of the types involved might have modifiers
+            // on it, but the underlying types are otherwise the same.
+            //
+            auto toModified = as<ModifiedType>(toType);
+            auto toBase = toModified ? toModified->base : toType;
+            //
+            auto fromModified = as<ModifiedType>(fromType);
+            auto fromBase = fromModified ? fromModified->base : fromType;
+
+
+            if((toModified || fromModified) && toBase->equals(fromBase))
+            {
+                // We need to check each modifier present on either `toType`
+                // or `fromType`. For each modifier, it will either be:
+                //
+                // * Present on both types; these are a non-issue
+                // * Present only on `toType`
+                // * Present only on `fromType`
+                //
+                if( toModified )
+                {
+                    for( auto modifier : toModified->modifiers )
+                    {
+                        if(_hasMatchingModifier(fromModified, modifier))
+                            continue;
+
+                        // If `modifier` is present on `toType`, but not `fromType`,
+                        // then we need to know whether this modifier can be added
+                        // to the type of an expression as part of coercion.
+                        //
+                        if( !_canModifierBeAddedDuringCoercion(modifier) )
+                        {
+                            return _failedCoercion(toType, outToExpr, fromExpr);
+                        }
+                    }
+                }
+                if( fromModified )
+                {
+                    for( auto modifier : fromModified->modifiers )
+                    {
+                        if(_hasMatchingModifier(toModified, modifier))
+                            continue;
+
+                        // If `modifier` is present on `fromType`, but not `toType`,
+                        // then we need to know whether this modifier can be dropped
+                        // to the type of an expression as part of coercion.
+                        //
+                        if( !_canModifierBeDroppedDuringCoercion(modifier) )
+                        {
+                            return _failedCoercion(toType, outToExpr, fromExpr);
+                        }
+                    }
+                }
+
+                // If all the modifiers were okay, we can convert.
+
+                // TODO: we may need a cost to allow disambiguation of overloads based on modifiers?
+                if(outCost)
+                {
+                    *outCost = kConversionCost_None;
+                }
+                if( outToExpr )
+                {
+                    *outToExpr = createModifierCastExpr(toType, fromExpr);
+                }
+
+                return true;
+            }
+        }
+
         // Coercion from an initializer list is allowed for many types,
         // so we will farm that out to its own subroutine.
         //
@@ -931,6 +1064,18 @@ namespace Slang
         return expr;
     }
 
+    Expr* SemanticsVisitor::createModifierCastExpr(
+        Type*    toType,
+        Expr*    fromExpr)
+    {
+        ModifierCastExpr* expr = m_astBuilder->create<ModifierCastExpr>();
+        expr->loc = fromExpr->loc;
+        expr->type = QualType(toType);
+        expr->valueArg = fromExpr;
+        return expr;
+    }
+
+
     Expr* SemanticsVisitor::coerce(
         Type*    toType,
         Expr*    fromExpr)