diff options
| author | jsmall-nvidia <jsmall@nvidia.com> | 2019-05-22 12:00:21 -0400 |
|---|---|---|
| committer | Tim Foley <tfoleyNV@users.noreply.github.com> | 2019-05-22 09:00:20 -0700 |
| commit | 3247174cdb00836435794e3f07daad70bc92b66f (patch) | |
| tree | d83ccbb72ae3d5eb66c14fcaff7984962549010e /source/slang/ir.h | |
| parent | 7a24a4285c342ca5dea9a3b3fe176c4348aa9a51 (diff) | |
Hotfix/improve glsl semantic conversion review (#968)
* Small changes based on review
* Remove the explicit 'nominal' tests
* Made isValueEqual and isEqual on on IRConstant take a pointer
* Small improvements to comments, and clarity of using 'nominal'
* Simplify comparison by just using isTypeOperandEqual as basis for isTypeEqual
* Use cross compile to test half-texture.slang on glsl
* Don't need half-texture.slang.expected
* Fix handling of nominal comparison based on review, ensuring that for nominal insts, they can only be compared by pointer.
Diffstat (limited to 'source/slang/ir.h')
| -rw-r--r-- | source/slang/ir.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/slang/ir.h b/source/slang/ir.h index 47c672a99..e7f9dff75 100644 --- a/source/slang/ir.h +++ b/source/slang/ir.h @@ -546,10 +546,10 @@ struct IRConstant : IRInst UnownedStringSlice getStringSlice(); /// True if constants are equal - bool equal(IRConstant& rhs); + bool equal(IRConstant* rhs); /// True if the value is equal. /// Does *NOT* compare if the type is equal. - bool isValueEqual(IRConstant& rhs); + bool isValueEqual(IRConstant* rhs); /// Get the hash int getHashCode(); |