summaryrefslogtreecommitdiffstats
path: root/source/slang/bytecode.cpp
diff options
context:
space:
mode:
authorTim Foley <tfoleyNV@users.noreply.github.com>2018-02-08 14:46:12 -0800
committerGitHub <noreply@github.com>2018-02-08 14:46:12 -0800
commitc7c97ad4bb62b83efd6e26cdd4f38ebf164ec40e (patch)
treedb419221788d50dd1e8940b547713e5dcfceb48d /source/slang/bytecode.cpp
parent112caca00ba9bfd9e1051bb94969efa9e74c6c03 (diff)
Basic IR support for `static const` globals (#404)
* Basic IR support for `static const` globals Our strategy for lowering global *variables* can fall back to putting their initialization into a function, but that isn't really appropriate for global constants (it also isn't appropriate for arrays, but we'll need to deal with that seaprately). This change adds a distinct case for global constants (rather than treating them as variables), and forces the emission logic to always emit them as a single expression. Doing this makes assumptions about how the IR for these constants gets emitted (and what optimziations might do to it). In order to make things work, I had to switch the handling of initializer-list expressions to not be lowered via temporaries and mutation (since that isn't a good fit for reverting to a single expression). I've added a single test case to ensure that this works in the simplest scenario. My next priority will be to see if this unblocks my work in Falcor. * Fixup: bug fixes
Diffstat (limited to 'source/slang/bytecode.cpp')
-rw-r--r--source/slang/bytecode.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/source/slang/bytecode.cpp b/source/slang/bytecode.cpp
index 3b92b78e1..eb6b755fc 100644
--- a/source/slang/bytecode.cpp
+++ b/source/slang/bytecode.cpp
@@ -918,12 +918,15 @@ BytecodeGenerationPtr<BCSymbol> generateBytecodeSymbolForInst(
break;
case kIROp_global_var:
+ case kIROp_global_constant:
{
auto bcVar = allocate<BCSymbol>(context);
bcVar->op = inst->op;
bcVar->typeID = getTypeID(context, inst->type);
+ // TODO: actually need to intialize with body instructions
+
return bcVar;
}
break;