diff options
| author | jsmall-nvidia <jsmall@nvidia.com> | 2021-04-29 15:45:25 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-29 15:45:25 -0400 |
| commit | ad6f3070251f25cf022c231b8567d78e98061127 (patch) | |
| tree | 1fa9d2058f8e86710a9e716e493473217b6dff77 /source/core/windows | |
| parent | 972bd3c4c24b06501c52127416afb763a066b8ad (diff) | |
Simplify CommandLine by removing Escaping (#1825)
* #include an absolute path didn't work - because paths were taken to always be relative.
* Split out StringEscapeUtil.
* Added StringEscapeUtil.
* Fix typo in unix quoting type.
* Small comment improvements.
* Try to fix linux linking issue.
* Fix typo.
* Attempt to fix linux link issue.
* Update VS proj even though nothing really changed.
* Fix another typo issue.
* Fix for windows issue.
Fixed bug.
* Make separate Utils for escaping.
* Fix typo.
* Split out into StringEscapeHandler.
* Windows shell does handle removing quotes (so remove code to remove them).
* Handle unescaping if not initiating using the shell.
* Slight improvement around shell like decoding.
* Simplify command extraction.
* Add shared-library category type.
* Fix bug in command extraction.
* Typo in transcendental category.
* Enable unit-test on in smoke test category.
* Make parsing failing output as a failing test.
* Fixes for transcendental tests. Disable tests that do not work.
* Changed category parsing.
* Removed the TestResult parameter from _gatherTestsForFile.
Made testsList only output.
* Remove testing if all tests were disabled.
* Make args of CommandLine always unescaped.
* Add category.
* Don't need escaping on unix/linux.
* Remove some no longer used functions.
Diffstat (limited to 'source/core/windows')
| -rw-r--r-- | source/core/windows/slang-win-process-util.cpp | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/source/core/windows/slang-win-process-util.cpp b/source/core/windows/slang-win-process-util.cpp index 9cc567318..4039361a4 100644 --- a/source/core/windows/slang-win-process-util.cpp +++ b/source/core/windows/slang-win-process-util.cpp @@ -169,14 +169,7 @@ static DWORD WINAPI _readerThreadProc(LPVOID threadParam) for (const auto& arg : commandLine.m_args) { cmd << " "; - if (arg.type == CommandLine::ArgType::Unescaped) - { - StringEscapeUtil::appendMaybeQuoted(escapeHandler, arg.value.getUnownedSlice(), cmd); - } - else - { - cmd << arg.value; - } + StringEscapeUtil::appendMaybeQuoted(escapeHandler, arg.getUnownedSlice(), cmd); } return cmd.ToString(); } |