Try to improve handling of failures during compilation

The change is mostly about trying to make sure the compiler "fails safe" when it encounters an internal assumption that isn't met.
Most internal errors will now throw exceptions (yes, exceptions are evil, but this will work for now), and these get caught in `spCompile` so that they don't propagate to the user (they just see a message that compilation aborted due to an internal error).

Subsequent changes are going to need to work on diagnosing as many of these situations as possible, so that users can at least know what construct in their code was unexpected or unhandled by the compiler.

1 files changed, 3 insertions, 2 deletions

diff --git a/source/core/smart-pointer.h b/source/core/smart-pointer.h
index fea149e06..87cb40d70 100644
--- a/source/core/smart-pointer.h
+++ b/source/core/smart-pointer.h
@@ -1,6 +1,7 @@
 #ifndef FUNDAMENTAL_LIB_SMART_POINTER_H
 #define FUNDAMENTAL_LIB_SMART_POINTER_H
 
+#include "common.h"
 #include "type-traits.h"
 
 #include <assert.h>
@@ -36,7 +37,7 @@ namespace Slang
 
         void releaseReference()
         {
-            assert(referenceCount != 0);
+            SLANG_ASSERT(referenceCount != 0);
             if(--referenceCount == 0)
             {
                 delete this;
@@ -45,7 +46,7 @@ namespace Slang
 
         bool isUniquelyReferenced()
         {
-            assert(referenceCount != 0);
+            SLANG_ASSERT(referenceCount != 0);
             return referenceCount == 1;
         }
     };