Feature/lex memory reduction (#762)

* Only do scrubbing if needed. When allocating content try to limit size (with scrubbing each token takes up 1k), now it's 16 bytes min size.

* Don't allocate for every call to write on the CallbackWriter - use the m_appendBuffer.

* Don't allocate memory for CallbackWriter use m_appendBuffer.

* Use UnownedStringSlice for suffix output for parsing float/int literals.
Fix typo in invalidFloatingPointLiteralSuffix

* Using memory arena to hold tokens that are not in SourceManager.

* Improve comment on lexing.

* Make UnownedStringSlice allocation simpler on SourceManager.

* Fix error on gcc around UnownedStringSlice - because VC converted string + UnownedStringSlice automatically into a String.

* Fix generateName needing concat string for gcc.

* When constructing a Token in parseAttributeName - because it's a Identifier, we have to set the Name.

* Remove translation through String on getIntrinsicOp

* Make func-cbuffer-param disablable with -exclude compatibility-issue

* Move memory leak in render-test.

* From review - can just use "?:" instead of performing a concat.

1 files changed, 2 insertions, 2 deletions

diff --git a/source/core/slang-string.h b/source/core/slang-string.h
index 5a20d8b75..4c87ce81e 100644
--- a/source/core/slang-string.h
+++ b/source/core/slang-string.h
@@ -111,9 +111,9 @@ namespace Slang
             return -1;
         }
 
-        const char& operator[](int i) const
+        const char& operator[](UInt i) const
         {
-            assert(i >= 0 && i < int(endData - beginData));
+            assert(i < UInt(endData - beginData));
             return beginData[i];
         }