diff options
| author | Julius Ikkala <julius.ikkala@gmail.com> | 2025-09-08 20:07:53 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-08 17:07:53 +0000 |
| commit | 8b512c49d163af1df33e940acc3c4a230f0d00b7 (patch) | |
| tree | 25580be0692e41f82af90aaf615a59617da51641 /source/core/slang-persistent-cache.cpp | |
| parent | c0d7405d831faa6208b27fe56bf66fb0b138dcc5 (diff) | |
Don't emit ArrayStride 0 for RWStructuredBuffer pointers (#8397)
Fixes #8396 by not emitting the `ArrayStride` when it would've been
zero. The problem is caused by #7848, more details in the issue
description.
I checked that with equivalent GLSL code, glslangValidator does not emit
any `ArrayStride`. I assume that the addition of `storageClass ==
SpvStorageClassStorageBuffer` to line 1848 is not a mistake. If it is,
that addition could also be simply reverted to fix this issue, I tested
that option as well. With these changes, Slang tests work locally on my
PC again.
Related to this; it'd be nice to have GPUs from multiple vendors in the
CI to avoid this kind of thing happening again. Or even just llvmpipe;
that doesn't even require a GPU and would add at least one more driver
to test with.
Diffstat (limited to 'source/core/slang-persistent-cache.cpp')
0 files changed, 0 insertions, 0 deletions
