diff options
| author | Tim Foley <tfoleyNV@users.noreply.github.com> | 2020-06-30 12:25:27 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-06-30 12:25:27 -0700 |
| commit | 8ced9d2a0efaca8f6dbdaf427be1db52844787b5 (patch) | |
| tree | 20dc0a8d3ec838253823558fc4df8a82ddd1a910 /source/core/core.vcxproj | |
| parent | dc44b08ec377106a0c6d1c022e2754d9e11c579f (diff) | |
Clean up unused code for IR object ownership (#1416)
There was a small but non-trivial amount of code across `IRModule`, the `ObjectScopeManager`, and `StringRepresentationCache` that had to do with managing the lifetimes of `RefObject`s that might be referenced by IR instructions (and thus need to be kept alive for the lifetime of the IR module).
We have long since migrated to a model where IR instruction do not include owned references to `RefObject`s, so these facilities weren't actually needed. This streamlines `IRModule`'s declaration, and trims code that we aren't actually using.
One note for the future is that the `StringRepresentationCache` no longer does what its name implies (it is not a cache of `StringRepresentation`s), so we should consider giving it a more narrowly scoped name. I didn't include that in this change because I wanted to keep the diffs narrow and easy to review.
A follow-on renaming change should be trivial if/when we can agree on what the type should be called at this point. Alternatively, we could simply bake the functionality of `StringRepresentationCache` into he IR deserialiation logic itself, since that is the only code using it.
Diffstat (limited to 'source/core/core.vcxproj')
| -rw-r--r-- | source/core/core.vcxproj | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/source/core/core.vcxproj b/source/core/core.vcxproj index 636edb46a..8c4e7753c 100644 --- a/source/core/core.vcxproj +++ b/source/core/core.vcxproj @@ -189,7 +189,6 @@ <ClInclude Include="slang-math.h" /> <ClInclude Include="slang-memory-arena.h" /> <ClInclude Include="slang-nvrtc-compiler.h" /> - <ClInclude Include="slang-object-scope-manager.h" /> <ClInclude Include="slang-offset-container.h" /> <ClInclude Include="slang-platform.h" /> <ClInclude Include="slang-process-util.h" /> @@ -225,7 +224,6 @@ <ClCompile Include="slang-io.cpp" /> <ClCompile Include="slang-memory-arena.cpp" /> <ClCompile Include="slang-nvrtc-compiler.cpp" /> - <ClCompile Include="slang-object-scope-manager.cpp" /> <ClCompile Include="slang-offset-container.cpp" /> <ClCompile Include="slang-platform.cpp" /> <ClCompile Include="slang-random-generator.cpp" /> |