summaryrefslogtreecommitdiffstats
path: root/source/compiler-core/slang-command-line-args.cpp
diff options
context:
space:
mode:
authorT. Foley <tfoleyNV@users.noreply.github.com>2021-05-27 13:40:17 -0700
committerGitHub <noreply@github.com>2021-05-27 13:40:17 -0700
commit63dcc7acf4784d95407866730a70f5d37d391b88 (patch)
tree58cf716422ba5842a5a06230509a5d83eb370f4f /source/compiler-core/slang-command-line-args.cpp
parent15f5cffc3026a5faed7046ae7d75ec6b56cf4a4c (diff)
Fix a bug in struct inheritance (#1861)
During lowering from AST to IR, the Slang compiler translates code that uses `struct` inheritance: ```hlsl struct Base { int a; } struct Derived : Base {} ``` into code where the inheritance relationship is "witnessed" by a simple field: ```hlsl struct Base { int a; } struct Derived { Base __anonymous_field__; } ``` The underlying bug here is that the `__anonymous_field__` that the compiler generated during IR lowering was not being given any linkage decorations (no mangled name). As a result, if multiple separately-compiled modules all access that field they could disagree on its identity as an IR instruction. This could lead to output code being generated where the declaration of `__anonymous_field__` uses one IR instruction, but accesses use another. This change includes a fix for the issue, and a test that serves as a reproducer for the original problem.
Diffstat (limited to 'source/compiler-core/slang-command-line-args.cpp')
0 files changed, 0 insertions, 0 deletions