diff options
| author | kaizhangNV <149626564+kaizhangNV@users.noreply.github.com> | 2024-07-19 13:42:31 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-19 11:42:31 -0700 |
| commit | adf758c8c4032afcd96d995840bd697d2adef34c (patch) | |
| tree | 2450d2d953093e0cdc2e720c554ca10553f958ca /include | |
| parent | 7488b15d21ab3d72b2598da80712c00d368518bd (diff) | |
Fix the issue of name mangling (#4691)
* Fix the issue of name mangle
During our name mangling, we should add the direction of the parameter
in the name, otherwise it could have the name collision which will
result in invalid code generation:
e.g.
// in slang-module.slang
export func(float a) { ...}
// in test.slang
extern func(inout float a);
when we compile test.slang, slang will pass a pointer type to the
'func', however, in the slang-module.slang, `func` expects a value
instead of pointer. This will lead the wrong spirv code.
So we should add the parameter direction into the mangle name such
that above two symbols will have the different mangled names, and
we will catch this during IR-link stage.
* Change to use to get param direction
* Address few comments
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions
