diff options
| author | Yong He <yonghe@outlook.com> | 2021-04-20 13:17:29 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-20 13:17:29 -0700 |
| commit | 34fba7b5e726136c6eee8a318ab9a75381399c00 (patch) | |
| tree | 39a496c7052256cef9b089b78ab4bd48316571bd /examples/model-viewer/shaders.slang | |
| parent | 6bba674f9d732eccc27dcf004611e6a8eb9bc14e (diff) | |
Various fixes to make `model-viewer` example almost working. (#1801)
* Fixing `PseudoPtr` legalization and `gfx` lifetime issues.
* Fixing `model-viewer` example.
This change contains various fixes to bring `model-viewer` example to fully functional. These fixes include:
1. Add `spReflectionTypeLayout_getSubObjectRangeSpaceOffset` function to return the space index for a sub object referenced through a `ParameterBlock` binding.
2. Make sure `D3D12Device` specifies column major matrix order creating a Slang session.
3. Fix `platform::Window::close()` and `platform::Application::quit()`.
4. Fix memory leak during `model-viewer''s model loading.
5. Fix command buffer recording in `model-viewer`.
With these changes, model viewer can now produce an image with a gray cube. The lighting is still incorrect becuase the `gfx` shader object implementation still does not handle "pending layout" resulting from global existential parameters.
* Fix d3d12 root signature creation.
* Use row-major matrix layout in model-viewer
Diffstat (limited to 'examples/model-viewer/shaders.slang')
| -rw-r--r-- | examples/model-viewer/shaders.slang | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/examples/model-viewer/shaders.slang b/examples/model-viewer/shaders.slang index 0cc0d802f..0005b427b 100644 --- a/examples/model-viewer/shaders.slang +++ b/examples/model-viewer/shaders.slang @@ -468,7 +468,6 @@ float4 fragmentMain( // `illuminance` loop in RenderMan Shading Language works. // - float3 color = gLightEnv.illuminate(g, brdf, V); - + float3 color = saturate(gLightEnv.illuminate(g, brdf, V) + float3(0.3)); return float4(color, 1); } |