diff options
| author | cheneym2 <acheney@nvidia.com> | 2024-09-17 01:24:44 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-16 22:24:44 -0700 |
| commit | 25d155937402120292cff9e6f5a31c1d45a2ecbf (patch) | |
| tree | 960687977ae0b8c114ed1d4d375246b94061a1bf /docs | |
| parent | d866c0b9dfc0fdc8ad8cede4d7a8593f7ddf4716 (diff) | |
release-note.sh fixes (#5068)
Add a gh.exe search path that works with cygwin installations.
Do not bail out from the breaking changes loop when a change is
found without PR#. Instead, continue to the next one. This fixes
an issue where [BREAKING] changes appear in the detailed change
list by not in the summary of breaking changes.
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/scripts/release-note.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/docs/scripts/release-note.sh b/docs/scripts/release-note.sh index f1a93137a..3def707cc 100644 --- a/docs/scripts/release-note.sh +++ b/docs/scripts/release-note.sh @@ -16,7 +16,7 @@ verbose=true $verbose && echo "Reminder: PLEASE make sure your local repo is up-to-date before running the script." >&2 gh="" -for candidate in "$(which gh.exe)" "/mnt/c/Program Files/GitHub CLI/gh.exe" "/c/Program Files/GitHub CLI/gh.exe" +for candidate in "$(which gh.exe)" "/mnt/c/Program Files/GitHub CLI/gh.exe" "/c/Program Files/GitHub CLI/gh.exe" "/cygdrive/c/Program Files/GitHub CLI/gh.exe" do if [ -x "$candidate" ] then @@ -51,7 +51,7 @@ do # Get PR number from the git commit title pr="$(echo "$line" | grep '#[1-9][0-9][0-9][0-9][0-9]*' | sed 's|.* (\#\([1-9][0-9][0-9][0-9][0-9]*\))|\1|')" - [ "x$pr" = "x" ] && break + [ "x$pr" = "x" ] && continue # Check if the PR is marked as a breaking change if "$gh" issue view $pr --json labels | grep -q 'pr: breaking change' |