diff options
| author | ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> | 2025-08-08 13:19:25 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-08-08 20:19:25 +0000 |
| commit | 07f21ee31b5f427edb72d5578f713b3da3f3b96f (patch) | |
| tree | 777df480b51f488a296bcf0c231afc3cfff2afdc /docs/user-guide/toc.html | |
| parent | 719772c01a8ee8afa81cded249d6a51e33e17d8d (diff) | |
Error if super-type capabilities are a super-set of sub-type (#7452)
Fixes: #7410
Changes:
1. super-type capabilities must be a super-set of sub-type capabilities
(and support the same shader stages/targets)
* InheritanceDecl visits super-type to inherit it's capabilities;
validate InheritanceDecl capabilities against sub-type
* visit all container decl's with a default case
* clean up functionDeclBase visitor
* Simplify `diagnoseUndeclaredCapability` by moving logic into
capability checking (more correct*)
3. added changed behavior to documentation
4. fixed some incorrect capabilities
5. **we do not** diagnose capability errors on interface
requirement-to-implementation if both lack explicit capability
requirements. This change is to work around a slangpy regression (test
case for the failing situation is in
`tests\language-feature\capability\capability-interface-extension-1.slang`),
Note: maybe for slang-2026 we don't do this?
6. requirement & implementation must support the same shader
stage/target. This was changed because otherwise we can have cases where
`X` inherits from `Y`, but `Y` is only expected to be used in `glsl`
whilst `X` is expected to be used in `hlsl | glsl`
7. removed
`tests/language-feature/capability/capabilitySimplification3.slang`
because it tests nothing special (redundant)
Note: not using rebase due to separate branches depending on this PR
---------
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
Diffstat (limited to 'docs/user-guide/toc.html')
| -rw-r--r-- | docs/user-guide/toc.html | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/docs/user-guide/toc.html b/docs/user-guide/toc.html index f559fec31..b32ad71da 100644 --- a/docs/user-guide/toc.html +++ b/docs/user-guide/toc.html @@ -68,9 +68,10 @@ <ul class="toc_list"> <li data-link="capabilities#capability-atoms-and-capability-requirements"><span>Capability Atoms and Capability Requirements</span></li> <li data-link="capabilities#conflicting-capabilities"><span>Conflicting Capabilities</span></li> -<li data-link="capabilities#requirements-in-parent-scope"><span>Requirements in Parent Scope</span></li> -<li data-link="capabilities#inference-of-capability-requirements"><span>Inference of Capability Requirements</span></li> -<li data-link="capabilities#inference-on-target_switch"><span>Inference on target_switch</span></li> +<li data-link="capabilities#capabilities-between-parent-and-members"><span>Capabilities Between Parent and Members</span></li> +<li data-link="capabilities#capabilities-between-subtype-and-supertype"><span>Capabilities Between Subtype and Supertype</span></li> +<li data-link="capabilities#capabilities-between-requirement-and-implementation"><span>Capabilities Between Requirement and Implementation</span></li> +<li data-link="capabilities#capabilities-of-functions"><span>Capabilities of Functions</span></li> <li data-link="capabilities#capability-aliases"><span>Capability Aliases</span></li> <li data-link="capabilities#validation-of-capability-requirements"><span>Validation of Capability Requirements</span></li> </ul> |