diff options
| author | jarcherNV <jarcher@nvidia.com> | 2025-08-06 20:18:00 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-08-07 03:18:00 +0000 |
| commit | f241b1438104973d719926eb74e2195715d7608a (patch) | |
| tree | e71e52b3c48f67bb38f4e984df6a7ff33e567726 | |
| parent | 631a4c37a597fab7599abc472f25d671bfe37751 (diff) | |
Fix atomic fp16 vector SPIRV emit (#8104)
Update the SPIRV emit of atomic fp16 vector extension from its previous
incorrect name to SPV_NV_shader_atomic_fp16_vector.
| -rw-r--r-- | source/slang/slang-emit-spirv.cpp | 4 | ||||
| -rw-r--r-- | tests/spirv/atomic-float16-vector.slang | 22 |
2 files changed, 24 insertions, 2 deletions
diff --git a/source/slang/slang-emit-spirv.cpp b/source/slang/slang-emit-spirv.cpp index 0a755cd6d..0449c6b88 100644 --- a/source/slang/slang-emit-spirv.cpp +++ b/source/slang/slang-emit-spirv.cpp @@ -3753,7 +3753,7 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex if (as<IRVectorType>(atomicInst->getDataType())->getElementType()->getOp() == kIROp_HalfType) { - ensureExtensionDeclaration(toSlice("VK_NV_shader_atomic_float16_vector")); + ensureExtensionDeclaration(toSlice("SPV_NV_shader_atomic_fp16_vector")); requireSPIRVCapability(SpvCapabilityAtomicFloat16VectorNV); } break; @@ -3781,7 +3781,7 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex if (as<IRVectorType>(atomicInst->getDataType())->getElementType()->getOp() == kIROp_HalfType) { - ensureExtensionDeclaration(toSlice("VK_NV_shader_atomic_float16_vector")); + ensureExtensionDeclaration(toSlice("SPV_NV_shader_atomic_fp16_vector")); requireSPIRVCapability(SpvCapabilityAtomicFloat16VectorNV); } break; diff --git a/tests/spirv/atomic-float16-vector.slang b/tests/spirv/atomic-float16-vector.slang new file mode 100644 index 000000000..f9602a948 --- /dev/null +++ b/tests/spirv/atomic-float16-vector.slang @@ -0,0 +1,22 @@ +//TEST:SIMPLE(filecheck=CHECK):-target spirv -entry computeMain -stage compute -emit-spirv-directly
+
+//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out,name=outputBuffer
+RWStructuredBuffer<float> outputBuffer;
+
+//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):name=workBuffer
+RWStructuredBuffer<half2> workBuffer;
+
+[numthreads(1, 1, 1)]
+void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
+{
+ half2 originalValue;
+
+ // Direct atomic operation on half2 should trigger the SPV_NV_shader_atomic_fp16_vector extension
+ originalValue = __atomic_add(workBuffer[0], half2(1.0h, 2.0h));
+
+ outputBuffer[0] = float(originalValue.x);
+ outputBuffer[1] = float(originalValue.y);
+}
+
+// CHECK: OpCapability AtomicFloat16VectorNV
+// CHECK: OpExtension "SPV_NV_shader_atomic_fp16_vector"
|