diff options
| author | Anders Leino <aleino@nvidia.com> | 2025-01-05 11:16:38 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-05 09:16:38 +0000 |
| commit | f0431b8c223c39fb627381f09d1664131690c9fc (patch) | |
| tree | 76b1df176c2f437b33e16b78cfebfd9d9fe1dfd0 | |
| parent | 00e7542894bec76054d0a4f74033b20064b58d4c (diff) | |
CI: Build the full slang-wasm.[js|wasm] targets instead of just the slang library. (#5998)
A recent build breakage for slang-wasm.[js|wasm] was not noticed by CI since it built the
slang library target instead of the slang-wasm.js "executable" target.
(We added a that used objcopy to split debug info from executables. objcopy does not
report errors when it finds object files with unexpected format inside static libraries,
but it *does* report errors when it's run on an exceutable of unexpected format, such as
in the case of slang-wasm.js.)
This closes #5959.
| -rw-r--r-- | .github/workflows/ci.yml | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e31b3b34d..63ccec18d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -125,10 +125,9 @@ jobs: mkdir generators cmake --install build --prefix generators --component generators emcmake cmake -DSLANG_GENERATORS_PATH=generators/bin --preset emscripten -DSLANG_SLANG_LLVM_FLAVOR=DISABLE - cmake --build --preset emscripten --config "$cmake_config" --target slang - [ -f "build.em/$cmake_config/lib/libslang.a" ] - [ -f "build.em/$cmake_config/lib/libcompiler-core.a" ] - [ -f "build.em/$cmake_config/lib/libcore.a" ] + cmake --build --preset emscripten --config "$cmake_config" --target slang-wasm + [ -f "build.em/$cmake_config/bin/slang-wasm.wasm" ] + [ -f "build.em/$cmake_config/bin/slang-wasm.js" ] else if [[ "${{ matrix.os }}" =~ "windows" && "${{ matrix.config }}" != "release" && "${{ matrix.config }}" != "releaseWithDebugInfo" ]]; then # Doing a debug build will try to link against a release built llvm, this |