summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYong He <yonghe@outlook.com>2024-08-01 13:25:47 -0700
committerGitHub <noreply@github.com>2024-08-01 13:25:47 -0700
commitd63f5e20f1edf7c51ca5c456baceb9eb9a84c95b (patch)
tree26432253494454c0b3ad921a2852184cbf06abc2
parent69dd7f40efd4988ba0fe3d4d5f6fee2d4d5d4a87 (diff)
Allow a enum case to reference a previously defined value. (#4768)
-rw-r--r--source/slang/slang-check-decl.cpp3
-rw-r--r--source/slang/slang-parser.cpp2
-rw-r--r--tests/language-feature/enums/reference-previous.slang15
3 files changed, 20 insertions, 0 deletions
diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp
index cd25e9d66..7211565dd 100644
--- a/source/slang/slang-check-decl.cpp
+++ b/source/slang/slang-check-decl.cpp
@@ -788,6 +788,9 @@ namespace Slang
if(as<ConstructorDecl>(decl))
return true;
+ if (as<EnumCaseDecl>(decl))
+ return true;
+
// Things nested inside functions may have dependencies
// on values from the enclosing scope, but this needs to
// be dealt with via "capture" so they are also effectively
diff --git a/source/slang/slang-parser.cpp b/source/slang/slang-parser.cpp
index aefe7f362..6510793f3 100644
--- a/source/slang/slang-parser.cpp
+++ b/source/slang/slang-parser.cpp
@@ -4945,6 +4945,7 @@ namespace Slang
parseOptionalInheritanceClause(parser, decl);
parser->ReadToken(TokenType::LBrace);
Token closingToken;
+ parser->pushScopeAndSetParent(decl);
while (!AdvanceIfMatch(parser, MatchedTokenType::CurlyBraces, &closingToken))
{
EnumCaseDecl* caseDecl = parseEnumCaseDecl(parser);
@@ -4955,6 +4956,7 @@ namespace Slang
parser->ReadToken(TokenType::Comma);
}
+ parser->PopScope();
decl->closingSourceLoc = closingToken.loc;
return decl;
});
diff --git a/tests/language-feature/enums/reference-previous.slang b/tests/language-feature/enums/reference-previous.slang
new file mode 100644
index 000000000..6dfbef39a
--- /dev/null
+++ b/tests/language-feature/enums/reference-previous.slang
@@ -0,0 +1,15 @@
+//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK): -shaderobj
+
+// Test that a enum case can reference a previously defined case.
+
+enum Check { V = 1, X = V+2 };
+
+//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out,name=outputBuffer
+RWStructuredBuffer<int> outputBuffer;
+
+[numthreads(1, 1, 1)]
+void computeMain(int3 dispatchThreadID : SV_DispatchThreadID)
+{
+ // CHECK: 3
+ outputBuffer[0] = Check.X;
+}