summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoraidanfnv <aidanf@nvidia.com>2025-05-14 15:08:39 -0700
committerGitHub <noreply@github.com>2025-05-14 22:08:39 +0000
commit8c98714df2198db1aff4ce6c6f7922850e400f80 (patch)
tree1349bc96b36eb61ab363f1ac24170e5d1f6955ae
parentd179f0eec263d6ba2d7c1594564d4161750b2369 (diff)
Remove readonly keyword from buffer pointer definitions (#7068)
For https://github.com/shader-slang/slang/issues/6880 This change removes the readonly keyword from buffer pointer definitions from the GLSL source emitter, to allow for mutable buffer pointers. Support for readonly will be readded when we add const pointer support later.
-rw-r--r--source/slang/slang-emit-glsl.cpp2
-rw-r--r--tests/hlsl-intrinsic/const-buffer-pointer.slang2
2 files changed, 2 insertions, 2 deletions
diff --git a/source/slang/slang-emit-glsl.cpp b/source/slang/slang-emit-glsl.cpp
index 850395d97..39b318ff3 100644
--- a/source/slang/slang-emit-glsl.cpp
+++ b/source/slang/slang-emit-glsl.cpp
@@ -2096,7 +2096,7 @@ void GLSLSourceEmitter::emitBufferPointerTypeDefinition(IRInst* type)
auto alignment = sizeAlignment.alignment;
m_writer->emit("layout(buffer_reference, std430, buffer_reference_align = ");
m_writer->emitInt64(alignment);
- m_writer->emit(") readonly buffer ");
+ m_writer->emit(") buffer ");
m_writer->emit(ptrTypeName);
m_writer->emit("\n");
m_writer->emit("{\n");
diff --git a/tests/hlsl-intrinsic/const-buffer-pointer.slang b/tests/hlsl-intrinsic/const-buffer-pointer.slang
index 9fd8a23d8..93f8bb0f6 100644
--- a/tests/hlsl-intrinsic/const-buffer-pointer.slang
+++ b/tests/hlsl-intrinsic/const-buffer-pointer.slang
@@ -12,7 +12,7 @@ struct MyStruct
float4x4 transform;
}
-// CHECK: layout(buffer_reference, std430, buffer_reference_align = 4) readonly buffer BufferPointer_MyStruct
+// CHECK: layout(buffer_reference, std430, buffer_reference_align = 4) buffer BufferPointer_MyStruct
// CHECK-NEXT: {
// CHECK-NEXT: MyStruct{{.*}} _data;
// CHECK-NEXT: }