summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJay Kwak <82421531+jkwak-work@users.noreply.github.com>2024-05-20 18:46:46 -0700
committerGitHub <noreply@github.com>2024-05-20 18:46:46 -0700
commit52b5bb43fd2933a30b405e7938ff62b209eea026 (patch)
tree00dbf0bd95d4f9e31bebeb582ee9fbfe987804b6
parente913cb9526c62727c35709166b93fdac3725acd2 (diff)
This commit increases the minimum CMake version from 3.20 to 3.25. (#4193)
I was trying to see if I can lower it to 3.16, but I found that we are currently using CMake feature that requires a version 3.25 not 3.20. This finding is not new. I made a similar change to CMakePresets.json a few days ago. At that time, I didn't realize that the same change had to be made for CMakeList.txt as well.
-rw-r--r--CMakeLists.txt2
-rw-r--r--CONTRIBUTION.md2
2 files changed, 2 insertions, 2 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 049fbf742..0f688f591 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.20)
+cmake_minimum_required(VERSION 3.25)
# Our module dir, include that now so that we can get the version automatically
# from git describe
diff --git a/CONTRIBUTION.md b/CONTRIBUTION.md
index becbfaf62..8a8a85a8b 100644
--- a/CONTRIBUTION.md
+++ b/CONTRIBUTION.md
@@ -94,7 +94,7 @@ Install CMake and Ninja.
```
$ sudo apt-get install cmake ninja-build
```
-> Warning: Currently the required CMake version is 3.20 or above.
+> Warning: Currently the required CMake version is 3.25 or above.
Run CMake with a following command to generate Makefile:
```