diff options
| author | Jay Kwak <82421531+jkwak-work@users.noreply.github.com> | 2025-07-24 19:26:02 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-07-25 02:26:02 +0000 |
| commit | 1a88488c309eab24b8f931c182353b271f22b44d (patch) | |
| tree | 2b35625ed56d30aa92dae02693095ecc52dc4810 | |
| parent | 138efb9c25aadd319db6e6300a263574d90e3391 (diff) | |
Fix metallib-asm target parsing by adding missing comma (#7902)
* Fix metallib-asm target parsing by adding missing comma
The metallib-asm target was not being recognized from command line because
of a syntax error in the target string definition in slang-type-text-util.cpp.
A missing comma after the first "metallib-asm" string caused C++ string
literal concatenation to create a malformed string.
Resolves #7774
Co-authored-by: Jay Kwak <jkwak-work@users.noreply.github.com>
* format code (#7910)
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
* regenerate command line reference (#7911)
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
---------
Co-authored-by: Claude Code <claude@anthropic.com>
Co-authored-by: Jay Kwak <jkwak-work@users.noreply.github.com>
Co-authored-by: slangbot <ellieh+slangbot@nvidia.com>
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
| -rw-r--r-- | docs/command-line-slangc-reference.md | 2 | ||||
| -rw-r--r-- | source/core/slang-type-text-util.cpp | 5 |
2 files changed, 2 insertions, 5 deletions
diff --git a/docs/command-line-slangc-reference.md b/docs/command-line-slangc-reference.md index 50a0a46c7..8cba2107f 100644 --- a/docs/command-line-slangc-reference.md +++ b/docs/command-line-slangc-reference.md @@ -1089,7 +1089,7 @@ Target * `host-host-callable` : Host callable for host execution * `metal` : Metal shader source * `metallib` : Metal Library Bytecode -* `Metal Library Bytecode assembly` +* `metallib-asm` : Metal Library Bytecode assembly * `wgsl` : WebGPU shading language source * `wgsl-spirv-asm`, `wgsl-spirv-assembly` : SPIR-V assembly via WebGPU shading language * `wgsl-spirv` : SPIR-V via WebGPU shading language diff --git a/source/core/slang-type-text-util.cpp b/source/core/slang-type-text-util.cpp index 39b68db45..d8435c503 100644 --- a/source/core/slang-type-text-util.cpp +++ b/source/core/slang-type-text-util.cpp @@ -77,10 +77,7 @@ static const TypeTextUtil::CompileTargetInfo s_compileTargetInfos[] = { {SLANG_HOST_HOST_CALLABLE, "", "host-host-callable", "Host callable for host execution"}, {SLANG_METAL, "metal", "metal", "Metal shader source"}, {SLANG_METAL_LIB, "metallib", "metallib", "Metal Library Bytecode"}, - {SLANG_METAL_LIB_ASM, - "metallib-asm" - "metallib-asm", - "Metal Library Bytecode assembly"}, + {SLANG_METAL_LIB_ASM, "metallib-asm", "metallib-asm", "Metal Library Bytecode assembly"}, {SLANG_WGSL, "wgsl", "wgsl", "WebGPU shading language source"}, {SLANG_WGSL_SPIRV_ASM, "wgsl-spirv-asm", |