diff options
| author | Pavel Asyutchenko <sventeam@yandex.ru> | 2025-03-26 06:27:23 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-03-26 05:27:23 +0000 |
| commit | 05f24d294917a2599d635fe2e53b75cdca26cfdd (patch) | |
| tree | a0de1da02758eef1bb77c4d4c06160537985ae52 | |
| parent | ff5e04f7f2e50466ed626193941c24b38494a785 (diff) | |
Fix SPV_KHR_maximal_reconvergence extension name spelling (#6687)
* Fix SPV_KHR_maximal_reconvergence extension name spelling
Vulkan validation layers emit warnings on lowercase khr.
* Move OpExtension check
| -rw-r--r-- | source/slang/slang-emit-spirv.cpp | 2 | ||||
| -rw-r--r-- | tests/hlsl-intrinsic/quad-control/quad-control-frag-many-entry-points.slang | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/source/slang/slang-emit-spirv.cpp b/source/slang/slang-emit-spirv.cpp index fda7b098d..18016d5fe 100644 --- a/source/slang/slang-emit-spirv.cpp +++ b/source/slang/slang-emit-spirv.cpp @@ -4650,7 +4650,7 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex } break; case kIROp_MaximallyReconvergesDecoration: - ensureExtensionDeclaration(UnownedStringSlice("SPV_khr_maximal_reconvergence")); + ensureExtensionDeclaration(UnownedStringSlice("SPV_KHR_maximal_reconvergence")); requireSPIRVExecutionMode(nullptr, dstID, SpvExecutionModeMaximallyReconvergesKHR); break; case kIROp_QuadDerivativesDecoration: diff --git a/tests/hlsl-intrinsic/quad-control/quad-control-frag-many-entry-points.slang b/tests/hlsl-intrinsic/quad-control/quad-control-frag-many-entry-points.slang index 2312f0c95..75fb75e8a 100644 --- a/tests/hlsl-intrinsic/quad-control/quad-control-frag-many-entry-points.slang +++ b/tests/hlsl-intrinsic/quad-control/quad-control-frag-many-entry-points.slang @@ -27,6 +27,7 @@ float4 getFragColor(float2 uv) { return fragColor; } +// CHECK_SPIRV: OpExtension "SPV_KHR_maximal_reconvergence" // CHECK_SPIRV: OpExecutionMode %fragmentMain1 MaximallyReconvergesKHR // CHECK_SPIRV: OpExecutionMode %fragmentMain1 QuadDerivativesKHR // CHECK_GLSL: layout(quad_derivatives) in |