diff options
| author | Harsh Aggarwal (NVIDIA) <haaggarwal@nvidia.com> | 2025-04-04 12:27:08 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-04 06:57:08 +0000 |
| commit | 4233d69cf88f1623cb573c8edb61456b24dc5339 (patch) | |
| tree | dcb63bfd59b9e6b9f100242de0fb89ceadf874ee /.github | |
| parent | df7c66be49822d650f8956662b16db49bae31d09 (diff) | |
fix(d3d11): correct parameter in VSSetConstantBuffers1 from uavCount … (#6690)
* fix(d3d11): correct parameter in VSSetConstantBuffers1 from uavCount to cbvCount (fixes #6531)
Root cause - Incorrect parameter passing in slang-rhi
1. slang-rhi #281 - Add the correct cbvCount for setting Constant Buffer
2. Prevent render tests from overwriting reference images
* Add missing tests/render/multiple-stage-io-locations.slang.3.expected.png
* Add more expected images from texture2d-gather
* Add new option: skipReferenceImageGeneration
For Github CI we set this to true - So we don't overwrite the expected
images
---------
Co-authored-by: Jay Kwak <82421531+jkwak-work@users.noreply.github.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/ci.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 611b40179..a8526dcaf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -170,6 +170,7 @@ jobs: -category ${{ matrix.test-category }} \ -api all-cpu \ -expected-failure-list tests/expected-failure-github.txt \ + -skip-reference-image-generation \ -show-adapter-info elif [[ "${{matrix.has-gpu}}" == "true" ]]; then "$bin_dir/slang-test" \ @@ -179,6 +180,7 @@ jobs: -expected-failure-list tests/expected-failure-github.txt \ -expected-failure-list tests/expected-failure-record-replay-tests.txt \ -expected-failure-list tests/expected-failure-github-runner.txt \ + -skip-reference-image-generation \ -show-adapter-info else "$bin_dir/slang-test" \ @@ -188,6 +190,7 @@ jobs: -expected-failure-list tests/expected-failure-github.txt \ -expected-failure-list tests/expected-failure-record-replay-tests.txt \ -expected-failure-list tests/expected-failure-github-runner.txt \ + -skip-reference-image-generation \ -show-adapter-info fi - name: Run Slang examples @@ -215,6 +218,7 @@ jobs: -emit-spirv-via-glsl \ -api vk \ -expected-failure-list tests/expected-failure.txt \ + -skip-reference-image-generation \ -show-adapter-info - uses: actions/upload-artifact@v4 if: steps.filter.outputs.should-run == 'true' && ! matrix.full-gpu-tests |