diff options
| author | Jay Kwak <82421531+jkwak-work@users.noreply.github.com> | 2024-07-18 14:31:27 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-18 14:31:27 -0700 |
| commit | be66cc88acebe87e175659df1afc2e4586ed8958 (patch) | |
| tree | 6f3e07cc0017e7d1483c176c1144829db47b375d /.github/workflows/ci.yml | |
| parent | ad379b7c532bef5ac49e6d730027ac8751e618d7 (diff) | |
Enable warnings-as-error for CI (#4659)
Enable warnings-as-error for CI
Closes #4664.
Uses glslang commit that fixed a compiler warning
Fixes a recent warning from external/CMakelist.txt
A new macro, `SLANG_MAYBE_UNUSED` is added for a future need.
Diffstat (limited to '.github/workflows/ci.yml')
| -rw-r--r-- | .github/workflows/ci.yml | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cdf315d8e..a45d7647c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,9 +32,11 @@ jobs: - { os: linux, runs-on: ubuntu-20.04 } - { os: macos, runs-on: macos-latest } - { os: windows, runs-on: windows-latest } - # When to have warnings - - warnings-as-errors: false - - { compiler: cl, warnings-as-errors true } + # Warnings are treated as errors by default. + # But we may want to disable it temporarily. + - { os: linux, warnings-as-errors: true } + - { os: macos, warnings-as-errors: true } + - { os: windows, warnings-as-errors: true } # Set a test category depending on the config, smoke by default, # quick or full conditionally otherwise - test-category: smoke @@ -47,7 +49,6 @@ jobs: config: release compiler: gcc platform: aarch64 - warnings-as-errors: false test-category: smoke full-gpu-tests: false runs-on: [self-hosted, Linux, ARM64] @@ -56,7 +57,6 @@ jobs: config: release compiler: cl platform: x86_64 - warnings-as-errors: false test-category: full full-gpu-tests: true runs-on: [Windows, self-hosted] |