From 88023aea669f258d66e53eab10215337a7f72853 Mon Sep 17 00:00:00 2001 From: Tim Foley Date: Thu, 19 Oct 2017 11:49:16 -0700 Subject: Reflection: allow querying of semantics on varying input/output (#224) This is functionality required to support a Falcor bug fix. Most of the code to compute the right semantic name/index for a parameter was already present. This change adds: - Storage for semantic name/index on every `VarLayout` - Note: this is wasteful and should be optimized later - A public API to query the semantic name/index - The contract is that this API returns `NULL` if the parameter had no semantic - A bit of work in `parameter-binding.cpp` to attach semantics to varying input/output when traversing varying parameters. - Note: this is intentionally set up so that it associates semantics even with non-leaf parameters, so that an API user can query the semantic of a `struct` parameter and know that its members will be assigned sequential semantic indices from its starting value. - Support for dumping this information in reflection tests One notable thing that I did *not* change here is that the reflection test fixture doesn't report information on the output of an entry point, even though it really should. That should be fixed in a separate change, though, because it would affect many of the expected outputs. --- tools/slang-reflection-test/main.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'tools/slang-reflection-test/main.cpp') diff --git a/tools/slang-reflection-test/main.cpp b/tools/slang-reflection-test/main.cpp index 9568dc3fe..f604ca1aa 100644 --- a/tools/slang-reflection-test/main.cpp +++ b/tools/slang-reflection-test/main.cpp @@ -183,6 +183,21 @@ static void emitReflectionVarBindingInfoJSON( { write(writer,"\n]"); } + + if (auto semanticName = var->getSemanticName()) + { + write(writer, ",\n"); + write(writer,"\"semanticName\": \""); + write(writer, semanticName); + write(writer, "\""); + + if (auto semanticIndex = var->getSemanticIndex()) + { + write(writer, ",\n"); + write(writer,"\"semanticIndex\": "); + write(writer, semanticIndex); + } + } } static void emitReflectionNameInfoJSON( -- cgit v1.2.3