From 34a1ff5226a526cc17c5baecd63637f69c324fc7 Mon Sep 17 00:00:00 2001
From: jsmall-nvidia <jsmall@nvidia.com>
Date: Sat, 22 May 2021 16:03:30 -0400
Subject: Improvements in -X support (#1852)

* #include an absolute path didn't work - because paths were taken to always be relative.

* Added SourceLoc handling for command line parsing.

* Fix typo in debug.

* Fix issue around the DiagnosticSink used in options parsing not having a writer available - by having DiagnosticSink parenting.

* Small rename for clarity.

* WIP extracting command line args for downstream tools.

* Unit tests/bug fixes around extracting args.

* Use DownstreamArgs in the EndToEndCompileRequest

* Passing downstream compiler options downstream.

* Fix issue with endToEndReq being nullptr.

* Fix issue with diagnostics number change.

* Small improvements to how the source line is displayed if it's too long.
Default to 120, as suggested in previous review.

* Make render test use x-args parsing and CommandArgReader.

* Added missing diagnostics.

* More DownstreamArgs to linkage so can be seen by 'components'.
Added dxc-x-arg test.

* Used combination of name and args instead of two Lists, which whilst equivalent was perhaps a little confusing.

* Added documentation for -X support.

* Added test for x-args parsing diagnostic. Improved diagnostic with list of known names.

* Fix issues from merge.

* Fix lookup for -matrix-layout-column-major in render test.

* Remove commented out line.
---
 tools/render-test/diagnostics.cpp | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 tools/render-test/diagnostics.cpp

(limited to 'tools/render-test/diagnostics.cpp')

diff --git a/tools/render-test/diagnostics.cpp b/tools/render-test/diagnostics.cpp
new file mode 100644
index 000000000..2bc337256
--- /dev/null
+++ b/tools/render-test/diagnostics.cpp
@@ -0,0 +1,21 @@
+// diagnostics.cpp
+#include "diagnostics.h"
+
+namespace Slang {
+
+namespace RenderTestDiagnostics
+{
+#define DIAGNOSTIC(id, severity, name, messageFormat) const DiagnosticInfo name = { id, Severity::severity, #name, messageFormat };
+#include "diagnostic-defs.h"
+#undef DIAGNOSTIC
+}
+
+static const DiagnosticInfo* const kDiagnostics[] =
+{
+#define DIAGNOSTIC(id, severity, name, messageFormat) &RenderTestDiagnostics::name, 
+#include "diagnostic-defs.h"
+#undef DIAGNOSTIC
+};
+
+
+} // namespace Slang
-- 
cgit v1.2.3