From 1681bc67fbae57b54b66c5dcfcbf315d1efa831b Mon Sep 17 00:00:00 2001
From: Jay Kwak <82421531+jkwak-work@users.noreply.github.com>
Date: Tue, 26 Aug 2025 14:38:57 -0700
Subject: Fail slang-test when VVL printed errors (#8280)

fixes https://github.com/shader-slang/slang/issues/8271

This PR does the following,
- Fail slang-test when there are VVL error messages.
- VVL error for `gfx-unit-test-tool/` were not captured properly by the
debug callback.
- Set an environment variable,
`VK_INSTANCE_LAYERS=VK_LAYER_KHRONOS_validation`, for CI and
VisualStudio project setup.
- Ignores VVL error about NullHandle is used for the acceleration
structure; a fix is at ToT of VVL and not available from release build
yet.
- Fix VVL error complaining about the varying inputs are not provided
for the tests, `gfx-unit-test-tool/linkTimeTypeLayout.internal` and
`gfx-unit-test-tool/linkTimeTypeLayoutNested.internal`.

---------

Co-authored-by: slangbot <ellieh+slangbot@nvidia.com>
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
---
 .../gfx-unit-test/link-time-type-layout-nested.cpp | 23 +++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

(limited to 'tools/gfx-unit-test/link-time-type-layout-nested.cpp')

diff --git a/tools/gfx-unit-test/link-time-type-layout-nested.cpp b/tools/gfx-unit-test/link-time-type-layout-nested.cpp
index 2c2c83a94..425224aa7 100644
--- a/tools/gfx-unit-test/link-time-type-layout-nested.cpp
+++ b/tools/gfx-unit-test/link-time-type-layout-nested.cpp
@@ -35,9 +35,9 @@ static Slang::Result loadProgram(
         // Define a regular struct that contains an Inner field
         public struct Outer
         {
-            float2 position;
+            float2 position : POSITION;
             Inner innerData;
-            float2 texCoord;
+            float2 texCoord : TEXCOORD;
         };
 
         // Vertex shader entry point that takes an Outer parameter
@@ -56,7 +56,7 @@ static Slang::Result loadProgram(
         export public struct Inner : IFoo
         {
             public float4 getFoo() { return this.data; }
-            float4 data;
+            float4 data : COLOR;
         }
     )";
 
@@ -212,8 +212,25 @@ void linkTimeTypeLayoutNestedImpl(rhi::IDevice* device, UnitTestContext* context
     validateNestedExternStructLayout(context, slangReflection);
 
     // Create a graphics pipeline to verify everything works
+    InputElementDesc inputElements[] = {
+        {"POSITION", 0, Format::RG32Float, 0, 0},  // Outer.position (float2)
+        {"COLOR", 0, Format::RGBA32Float, 8, 0},   // Outer.innerData.data (float4)
+        {"TEXCOORD", 0, Format::RG32Float, 24, 0}, // Outer.texCoord (float2)
+    };
+    VertexStreamDesc vertexStreams[] = {
+        {32, InputSlotClass::PerVertex, 0}, // sizeof(Outer) = 2*float2 + float4 = 32 bytes
+    };
+    InputLayoutDesc inputLayoutDesc = {};
+    inputLayoutDesc.inputElementCount = SLANG_COUNT_OF(inputElements);
+    inputLayoutDesc.inputElements = inputElements;
+    inputLayoutDesc.vertexStreamCount = SLANG_COUNT_OF(vertexStreams);
+    inputLayoutDesc.vertexStreams = vertexStreams;
+    auto inputLayout = device->createInputLayout(inputLayoutDesc);
+    SLANG_CHECK(inputLayout != nullptr);
+
     RenderPipelineDesc pipelineDesc = {};
     pipelineDesc.program = shaderProgram.get();
+    pipelineDesc.inputLayout = inputLayout;
     pipelineDesc.primitiveTopology = PrimitiveTopology::TriangleList;
 
     ComPtr<IRenderPipeline> pipelineState;
-- 
cgit v1.2.3