From ceb87b25b387411dbb7978caf04ecd9e948493e3 Mon Sep 17 00:00:00 2001 From: Sai Praveen Bangaru <31557731+saipraveenb25@users.noreply.github.com> Date: Mon, 26 Feb 2024 18:22:16 -0500 Subject: AD: Handle case where struct is created with `no_diff`-wrapped operands. (#3629) * Handle case where struct is created with `no_diff`-wrapped operands. * Add test to reproduce crash upon initializing a struct with `no_diff`-wrapped operand type * Add expected result for test --- tests/autodiff/make-struct-non-diff-operand.slang | 30 ++++++++++++++++++++++ ...make-struct-non-diff-operand.slang.expected.txt | 5 ++++ 2 files changed, 35 insertions(+) create mode 100644 tests/autodiff/make-struct-non-diff-operand.slang create mode 100644 tests/autodiff/make-struct-non-diff-operand.slang.expected.txt (limited to 'tests') diff --git a/tests/autodiff/make-struct-non-diff-operand.slang b/tests/autodiff/make-struct-non-diff-operand.slang new file mode 100644 index 000000000..cdfb6b6bc --- /dev/null +++ b/tests/autodiff/make-struct-non-diff-operand.slang @@ -0,0 +1,30 @@ +//TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -shaderobj -output-using-type +//TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj -output-using-type + +//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out,name=outputBuffer +RWStructuredBuffer outputBuffer; + +struct AggType : IDifferentiable +{ + float field1; + float field2; +} + +[BackwardDifferentiable] +AggType makeTypeWithNonDiffOps(no_diff float f1, float f2) +{ + AggType v = { f1, f2 }; + return v; +} + +[numthreads(1, 1, 1)] +void computeMain(uint3 dispatchThreadID: SV_DispatchThreadID) +{ + AggType v = { 0, 2.0 }; + AggType.Differential dv = { 1.3, 4.2 }; + + var f2pair = diffPair(2.0, 0.0); + + __bwd_diff(makeTypeWithNonDiffOps)(1.0, f2pair, dv); + outputBuffer[0] = f2pair.d; +} \ No newline at end of file diff --git a/tests/autodiff/make-struct-non-diff-operand.slang.expected.txt b/tests/autodiff/make-struct-non-diff-operand.slang.expected.txt new file mode 100644 index 000000000..0f62dd9c7 --- /dev/null +++ b/tests/autodiff/make-struct-non-diff-operand.slang.expected.txt @@ -0,0 +1,5 @@ +type: float +4.200000 +0.000000 +0.000000 +0.000000 -- cgit v1.2.3