From 3c3513ab501277333d1062ad2737ac4a60dac6f7 Mon Sep 17 00:00:00 2001 From: Tim Foley Date: Mon, 28 Jan 2019 14:20:44 -0800 Subject: Support function parameters of existential (interface) type (#802) * Support function parameters of existential (interface) type The basic idea here is that you can define a function that takes an interface-type parameter: ```hlsl interface IThing { void doSOmething(); } void coolFunction(IThing thing) { ... thing.doSomething() ... } ``` and call it with a concrete value that implements the given interface: ```hlsl struct Stuff : IThing { void doSomething() { /* secret sauce */ } } ... Stuff stuff; coolFunction(stuff); ``` The compiler implementation will specialize `coolFunction` based on the concrete type that was actually passed in, resulting in output code along the lines of: ```hlsl struct Stuff { ... } void Stuff_doSomething(Stuff this) { /* secret sauce */ } void coolFunction_Stuff(Stuff thing) { ... Stuff_doSomething(thing); } ``` In terms of implementation the new specialization approach has been integrated into the existing pass for generic specialization (which has been refactored significantly along the way), because generic specialization can open up opportunities for existential/interface simplification and vice versa, so there is no fixed interleaving of the two passes that can clean up everything. The new logic therefore subsumes the old code for simplifying existential types (which only worked on local variables) in `ir-existential.{h,cpp}`. The local simplification rules from that implementation have become part of the core specialization pass instead, so that they can open up further transformation opportunities enabled by existential-type simplifications. This code in place right now only handles the basic case of a function parameter that directly uses an interface type, and not one that wraps up an interface type in an array, structure, etc. Additional simplifications need to be introduced to deal with those cases as well. * fixup: typos --- tests/compute/interface-param.slang | 4 ---- 1 file changed, 4 deletions(-) (limited to 'tests') diff --git a/tests/compute/interface-param.slang b/tests/compute/interface-param.slang index 2e97a7fe2..1c16d2e9b 100644 --- a/tests/compute/interface-param.slang +++ b/tests/compute/interface-param.slang @@ -1,7 +1,5 @@ // interface-param.slang -//TEST_DISABLED: - // Test basic use of an interface as an existential type // for a value parameter, instead of just as a constraint // on a generic type parameter. @@ -10,8 +8,6 @@ //TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -dx12 //TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -//TEST:SIMPLE:-target hlsl -entry computeMain -stage compute -profile sm_5_1 -dump-ir - interface IHelper { int getVal(); -- cgit v1.2.3