From 996d4dc537272e36dde1d9c1110064d597fa212f Mon Sep 17 00:00:00 2001
From: Tim Foley <tfoley@nvidia.com>
Date: Tue, 27 Jun 2017 09:13:19 -0700
Subject: Emit global-scope parameters from imported files.

This fixes up a bug in the earlier change that provided reflection for imported parameters; I'd failed to confirm that the code generation logic can handle imported parameters correctly.

The main fix was to have an `import` declaration automatically use the global-scope layout already determined, sine imported parameters will in general appear there.
---
 tests/render/imported-parameters.hlsl  | 134 +++++++++++++++++++++++++++++++++
 tests/render/imported-parameters.slang |  23 ++++++
 2 files changed, 157 insertions(+)
 create mode 100644 tests/render/imported-parameters.hlsl
 create mode 100644 tests/render/imported-parameters.slang

(limited to 'tests')

diff --git a/tests/render/imported-parameters.hlsl b/tests/render/imported-parameters.hlsl
new file mode 100644
index 000000000..605214fc9
--- /dev/null
+++ b/tests/render/imported-parameters.hlsl
@@ -0,0 +1,134 @@
+//TEST(smoke,render):COMPARE_HLSL_GLSL_RENDER:
+
+// This test is trying to ensure that we can
+// correctly handle cases where top-level shader
+// parameters are declared in an `import`ed file.
+
+// Pull in Spire code depdendency using extended syntax:
+__import imported_parameters;
+
+#if defined(__HLSL__)
+
+struct AssembledVertex
+{
+	float3	position;
+	float3	color;
+};
+
+struct CoarseVertex
+{
+	float3	color;
+};
+
+struct Fragment
+{
+	float4 color;
+};
+
+// Vertex  Shader
+
+struct VertexStageInput
+{
+	AssembledVertex assembledVertex	: A;
+};
+
+struct VertexStageOutput
+{
+	CoarseVertex	coarseVertex	: CoarseVertex;
+	float4			sv_position		: SV_Position;
+};
+
+VertexStageOutput vertexMain(VertexStageInput input)
+{
+	VertexStageOutput output;
+
+	float3 position = input.assembledVertex.position;
+	float3 color	= input.assembledVertex.color;
+
+	output.coarseVertex.color = color;
+	output.sv_position = mul(modelViewProjection, float4(position, 1.0));
+
+	return output;
+	
+}
+
+// Fragment Shader
+
+struct FragmentStageInput
+{
+	CoarseVertex	coarseVertex	: CoarseVertex;
+};
+
+struct FragmentStageOutput
+{
+	Fragment fragment	: SV_Target;
+};
+
+FragmentStageOutput fragmentMain(FragmentStageInput input)
+{
+	FragmentStageOutput output;
+
+	float3 color = input.coarseVertex.color;
+
+	color = transformColor(color);
+
+	output.fragment.color = float4(color, 1.0);
+
+	return output;
+}
+
+#elif defined(__GLSL__)
+
+#version 420
+
+#define ASSEMBLED_VERTEX(QUAL)		\
+	/* */
+
+#define V2F(QUAL)			\
+	QUAL vec3 coarse_color;	\
+	/* */
+
+// Vertex  Shader
+
+#ifdef __GLSL_VERTEX__
+
+layout(location = 0)
+in vec3 assembled_position;
+
+layout(location = 1)
+in vec3 assembled_color;
+
+V2F(out)
+
+void main()
+{
+	vec3 position = assembled_position;
+	vec3 color	= assembled_color;
+
+	coarse_color = color;
+//	gl_Position = modelViewProjection * vec4(position, 1.0);
+	gl_Position = vec4(position, 1.0) * modelViewProjection;
+}
+
+#endif
+
+#ifdef __GLSL_FRAGMENT__
+
+V2F(in)
+
+layout(location = 0)
+out vec4 fragment_color;
+
+void main()
+{
+	vec3 color = coarse_color;
+
+	color = transformColor(color);
+
+	fragment_color = vec4(color, 1.0);
+}
+
+
+#endif
+
+#endif
diff --git a/tests/render/imported-parameters.slang b/tests/render/imported-parameters.slang
new file mode 100644
index 000000000..7c444a67b
--- /dev/null
+++ b/tests/render/imported-parameters.slang
@@ -0,0 +1,23 @@
+//TEST_IGNORE_FILE:
+
+// We are declaring the uniform shader parameters
+// in this imported file, to ensure that they are
+// emitted correctly.
+
+cbuffer Uniforms
+{
+	float4x4 modelViewProjection;
+};
+
+float3 transformColor(float3 color)
+{
+	float3 result;
+
+	result.x = sin(20.0 * (color.x + color.y));
+	result.y = saturate(cos(color.z * 30.0));
+	result.z = sin(color.x * color.y * color.z * 100.0);
+
+	result = 0.5 * (result + 1);
+
+	return result;
+}
\ No newline at end of file
-- 
cgit v1.2.3