From 915e05dcc4c03492087c2d3126ba01dff9ebe1be Mon Sep 17 00:00:00 2001 From: Anders Leino Date: Tue, 26 Nov 2024 19:02:59 +0200 Subject: WGSL: Fix issue where swizzle L-values are generated (#5682) * wgsl: Do not generate L-value swizzle expressions * Enable tests/language-feature/swizzles/matrix-swizzle-write-*.slang The following tests are enabled - tests/language-feature/swizzles/matrix-swizzle-write-swizzle.slang - tests/language-feature/swizzles/matrix-swizzle-write-array.slang This closes #5603. --- tests/expected-failure-github.txt | 2 -- tests/language-feature/swizzles/matrix-swizzle-write-array.slang | 2 -- tests/language-feature/swizzles/matrix-swizzle-write-swizzle.slang | 2 -- 3 files changed, 6 deletions(-) (limited to 'tests') diff --git a/tests/expected-failure-github.txt b/tests/expected-failure-github.txt index 862f3528e..df8962382 100644 --- a/tests/expected-failure-github.txt +++ b/tests/expected-failure-github.txt @@ -17,5 +17,3 @@ tests/language-feature/enums/strongly-typed-id.slang.1 syn (wgpu) tests/language-feature/generics/tuple.slang.1 syn (wgpu) tests/language-feature/generics/variadic-0.slang.4 syn (wgpu) tests/language-feature/shader-params/interface-shader-param-ordinary.slang.4 syn (wgpu) -tests/language-feature/swizzles/matrix-swizzle-write-array.slang.3 syn (wgpu) -tests/language-feature/swizzles/matrix-swizzle-write-swizzle.slang.3 syn (wgpu) diff --git a/tests/language-feature/swizzles/matrix-swizzle-write-array.slang b/tests/language-feature/swizzles/matrix-swizzle-write-array.slang index ea3fd2ffa..616a19b19 100644 --- a/tests/language-feature/swizzles/matrix-swizzle-write-array.slang +++ b/tests/language-feature/swizzles/matrix-swizzle-write-array.slang @@ -1,8 +1,6 @@ //TEST(compute):COMPARE_COMPUTE: -compute -shaderobj -output-using-type //TEST(compute, vulkan):COMPARE_COMPUTE: -vk -compute -shaderobj -output-using-type //TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl -output-using-type -// WGSL: Assign to swizzle expression not allowed #5603 -//DISABLE_TEST(compute):COMPARE_COMPUTE_EX:-wgpu // Test that matrix swizzle writes work correctly // Matrix swizzles can either be one or zero indexed diff --git a/tests/language-feature/swizzles/matrix-swizzle-write-swizzle.slang b/tests/language-feature/swizzles/matrix-swizzle-write-swizzle.slang index 1adde39dd..f1ad7bc6a 100644 --- a/tests/language-feature/swizzles/matrix-swizzle-write-swizzle.slang +++ b/tests/language-feature/swizzles/matrix-swizzle-write-swizzle.slang @@ -1,8 +1,6 @@ //TEST(compute):COMPARE_COMPUTE: -compute -shaderobj -output-using-type //TEST(compute, vulkan):COMPARE_COMPUTE: -vk -compute -shaderobj -output-using-type //TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl -output-using-type -// WGSL: Assign to swizzle expression not allowed #5603 -//DISABLE_TEST(compute):COMPARE_COMPUTE_EX:-wgpu // Test that writing to swizzles of matrix swizzles works correctly -- cgit v1.2.3