From 8a15efb37a33d3c2943be87a19cbf9b5e2e8432b Mon Sep 17 00:00:00 2001
From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com>
Date: Fri, 1 Aug 2025 12:36:29 -0700
Subject: Drain sink when single-argument constructor call fail (#7883)

* fix bug

* fix test

* push test changs for clarity

* fix bug

* fix test

* push test changs for clarity

* test what fails

* remove redundant code
---
 tests/bugs/gh-7856.slang                       | 52 ++++++++++++++++++++++++++
 tests/language-feature/pointer-cast-glsl.slang | 28 ++++++++++----
 2 files changed, 73 insertions(+), 7 deletions(-)
 create mode 100644 tests/bugs/gh-7856.slang

(limited to 'tests')

diff --git a/tests/bugs/gh-7856.slang b/tests/bugs/gh-7856.slang
new file mode 100644
index 000000000..b1edec8b5
--- /dev/null
+++ b/tests/bugs/gh-7856.slang
@@ -0,0 +1,52 @@
+//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): -target spirv -entry computeMain -stage compute
+
+enum A
+{
+    V1,
+    V2,
+    V3
+}
+
+enum B
+{
+    V1,
+    V2,
+    V3
+}
+
+struct Foo<T, A access = A::V1, B addrSpace = B::V1>
+{
+    int a;
+    __init(int b) { a = b; }
+    __init<U, A accessOther>(Foo<U, accessOther, addrSpace> ptr)
+    {
+    }
+
+    // internally Slang is throwing an error, we just don't drain the error
+    // from our sink
+    __init(uint64_t val) {}
+    __init(int64_t val) {}
+}
+
+extension int64_t
+{
+    __init<T, A access, B addrSpace>(Foo<T, access, addrSpace> t) {}
+}
+extension uint64_t
+{
+    __init<T, A access, B addrSpace>(Foo<T, access, addrSpace> t) {}
+}
+
+RWStructuredBuffer<int> output;
+
+[shader("compute")]
+[numthreads(1, 1, 1)]
+void computeMain(uint3 threadId: SV_DispatchThreadID)
+{
+    Foo<int, A.V1, B.V1> v1 = Foo<int, A.V1, B.V1>(1);
+
+    // CHECK: ([[# @LINE+1]]): error 30080
+    Foo<float, A.V1, B.V2> v2 = Foo<float, A.V1, B.V2>(v1);
+
+    output[0] = v1.a;
+}
diff --git a/tests/language-feature/pointer-cast-glsl.slang b/tests/language-feature/pointer-cast-glsl.slang
index 9e51c4328..a9516dae2 100644
--- a/tests/language-feature/pointer-cast-glsl.slang
+++ b/tests/language-feature/pointer-cast-glsl.slang
@@ -1,14 +1,28 @@
-//TEST:SIMPLE(filecheck=GLSL):-target glsl -entry main
+//TEST:SIMPLE(filecheck=GLSL):-target glsl -entry computeMain
+//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-vk -compute -emit-spirv-via-glsl
 
 // Test that pointer casts in GLSL generate constructor-style casts instead of C-style casts
 // This addresses issue https://github.com/shader-slang/slang/issues/7838
 
-//GLSL: BufferPointer__S1_2(address_0)
+//TEST_INPUT: set address = ubuffer(data=[1 2 3 4 5 6 7 8], stride=4);
+uniform uint64_t address;
+//TEST_INPUT: set pointer = ubuffer(data=[1 2 3 4 5 6 7 8], stride=4);
+uniform int* pointer;
+//TEST_INPUT: set outputBuffer = out ubuffer(data=[0 0 0 0 0 0 0 0], stride=4);
+RWStructuredBuffer<int> outputBuffer;
 
-[shader("vertex")]
-float4 main(uint vertexID : SV_VertexID, uint64_t address) : SV_Position
+// Ensure we have a proper GLSL supported ctor call for BDA
+//GLSL: BufferPointer__{{[a-zA-Z0-9_]+}}({{[a-zA-Z0-9_]+}}_0)
+
+// Ensure our GLSL code compiles and runs
+//BUF: 2
+
+[shader("compute")]
+[numthreads(1,1,1)]
+void computeMain() : SV_Position
 {
     // This should generate BufferPointer(address) instead of (BufferPointer)address in GLSL
-    let buffer = ConstBufferPointer<float4>(address);
-    return buffer[vertexID];
-}
\ No newline at end of file
+    let buffer1 = ConstBufferPointer<int>(address);
+    let buffer2 = ConstBufferPointer<int>(pointer);
+    outputBuffer[0] = buffer1[0] + buffer2[0];
+}
-- 
cgit v1.2.3