From 7bbe7b4780345181cb586b03504ff63f9b8d5c4c Mon Sep 17 00:00:00 2001 From: Sai Praveen Bangaru <31557731+saipraveenb25@users.noreply.github.com> Date: Fri, 7 Apr 2023 09:57:39 -0400 Subject: Fix crash on overloaded custom derivative function (#2782) * Fix issue with resolving overloaded custom forward derivative methods. * Add test --- tests/autodiff/overloaded-custom-deriv.slang | 41 ++++++++++++++++++++++ .../overloaded-custom-deriv.slang.expected.txt | 2 ++ 2 files changed, 43 insertions(+) create mode 100644 tests/autodiff/overloaded-custom-deriv.slang create mode 100644 tests/autodiff/overloaded-custom-deriv.slang.expected.txt (limited to 'tests') diff --git a/tests/autodiff/overloaded-custom-deriv.slang b/tests/autodiff/overloaded-custom-deriv.slang new file mode 100644 index 000000000..81f91974f --- /dev/null +++ b/tests/autodiff/overloaded-custom-deriv.slang @@ -0,0 +1,41 @@ +//TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -shaderobj -output-using-type +//TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj -output-using-type + +//TEST_INPUT:ubuffer(data=[0], stride=4):out,name=outputBuffer +RWStructuredBuffer outputBuffer; + +[ForwardDerivative(diff_f)] +float f(float v) +{ + return v * v; +} + +DifferentialPair diff_f(DifferentialPair v) +{ + return diffPair(v.p * v.p, 2 * v.d * v.p); +} + +[ForwardDerivative(diff_f)] +float2 f(float2 v) +{ + return v * v; +} + +DifferentialPair diff_f(DifferentialPair v) +{ + return diffPair(v.p * v.p, float2(2 * v.d.x * v.p.x, 0.0)); +} + +[ForwardDifferentiable] +float test(float v) +{ + return f(v) + f(float2(v, v)).x; +} + +[numthreads(1, 1, 1)] +void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID) +{ + var p = diffPair(3.0, 1.0); + let rs = __fwd_diff(test)(p); + outputBuffer[0] = rs.d; +} diff --git a/tests/autodiff/overloaded-custom-deriv.slang.expected.txt b/tests/autodiff/overloaded-custom-deriv.slang.expected.txt new file mode 100644 index 000000000..7da9c9037 --- /dev/null +++ b/tests/autodiff/overloaded-custom-deriv.slang.expected.txt @@ -0,0 +1,2 @@ +type: float +12.000000 -- cgit v1.2.3