From 5b23870eb0d3c0f1545304f67d15cffc16830107 Mon Sep 17 00:00:00 2001 From: Sai Praveen Bangaru <31557731+saipraveenb25@users.noreply.github.com> Date: Wed, 20 Sep 2023 16:47:56 -0400 Subject: Redirect destination-driven lowering logic to regular lowering for `SelectExpr` (#3219) * Redirect destination-driven lowering logic to regular lowering for select expr * Add test --- tests/autodiff/nan-select.slang | 36 ++++++++++++++++++++++++++++ tests/autodiff/nan-select.slang.expected.txt | 6 +++++ 2 files changed, 42 insertions(+) create mode 100644 tests/autodiff/nan-select.slang create mode 100644 tests/autodiff/nan-select.slang.expected.txt (limited to 'tests') diff --git a/tests/autodiff/nan-select.slang b/tests/autodiff/nan-select.slang new file mode 100644 index 000000000..31a185e6b --- /dev/null +++ b/tests/autodiff/nan-select.slang @@ -0,0 +1,36 @@ +//TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -shaderobj -output-using-type +//TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj -output-using-type + +//TEST_INPUT:ubuffer(data=[0 0 0 0 0], stride=4):out,name=outputBuffer +RWStructuredBuffer outputBuffer; + +typedef DifferentialPair dpfloat; +typedef float.Differential dfloat; + +[BackwardDifferentiable] +float f(float x) +{ + float k = x > 1e-8 ? atan2(x, x) : 0.0; + return k; +} + +[numthreads(1, 1, 1)] +void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID) +{ + { + dpfloat dpa = diffPair(2.0); + + __bwd_diff(f)(dpa, 1.0); + + outputBuffer[0] = dpa.d; // Expect: 0.0 + } + + { + dpfloat dpa = diffPair(0.0,); + + __bwd_diff(f)(dpa, 1.0); + + outputBuffer[1] = dpa.d; // Expect: 0.0, but if select is not turned into if-else, + // this will be 'inf' or 'nan' + } +} diff --git a/tests/autodiff/nan-select.slang.expected.txt b/tests/autodiff/nan-select.slang.expected.txt new file mode 100644 index 000000000..e070cf84d --- /dev/null +++ b/tests/autodiff/nan-select.slang.expected.txt @@ -0,0 +1,6 @@ +type: float +0.000000 +0.000000 +0.000000 +0.000000 +0.000000 -- cgit v1.2.3