From 492c6f2fd1a64c9d60a968b55bfd1000cc2ae8e7 Mon Sep 17 00:00:00 2001 From: Yong He Date: Tue, 4 Apr 2023 15:29:36 -0700 Subject: Diagnose on using assignment as predicate expr. (#2774) Co-authored-by: Yong He --- tests/compute/loop-unroll.slang | 3 +-- tests/diagnostics/assign-in-if.slang | 12 ++++++++++++ tests/diagnostics/assign-in-if.slang.expected | 14 ++++++++++++++ 3 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 tests/diagnostics/assign-in-if.slang create mode 100644 tests/diagnostics/assign-in-if.slang.expected (limited to 'tests') diff --git a/tests/compute/loop-unroll.slang b/tests/compute/loop-unroll.slang index 9a3fa3ba4..c0ea7686c 100644 --- a/tests/compute/loop-unroll.slang +++ b/tests/compute/loop-unroll.slang @@ -1,7 +1,6 @@ //TEST(compute):COMPARE_COMPUTE: -shaderobj //TEST(compute):COMPARE_COMPUTE:-dx12 -shaderobj -//TODO(JS): This test fails with a crash in CreateComputePipelineState, so disabled for now -//DISABLE_TEST(compute):COMPARE_COMPUTE:-dx12 -use-dxil -shaderobj +//TEST(compute):COMPARE_COMPUTE:-dx12 -use-dxil -shaderobj //TEST(compute):COMPARE_COMPUTE:-cpu -shaderobj //TEST(compute):COMPARE_COMPUTE:-cuda -shaderobj // Note VK output is not loop unrolled diff --git a/tests/diagnostics/assign-in-if.slang b/tests/diagnostics/assign-in-if.slang new file mode 100644 index 000000000..ef2222365 --- /dev/null +++ b/tests/diagnostics/assign-in-if.slang @@ -0,0 +1,12 @@ +//DIAGNOSTIC_TEST:REFLECTION:-stage compute -entry main -target hlsl + +[numthreads(1, 1, 1)] +void main( + uint3 dispatchThreadID : SV_DispatchThreadID) +{ + int a = 1; + if (a = 0) // error + {} + if ((a = 0)) // ok. + {} +} \ No newline at end of file diff --git a/tests/diagnostics/assign-in-if.slang.expected b/tests/diagnostics/assign-in-if.slang.expected new file mode 100644 index 000000000..373072d66 --- /dev/null +++ b/tests/diagnostics/assign-in-if.slang.expected @@ -0,0 +1,14 @@ +result code = 1 +standard error = { +tests/diagnostics/assign-in-if.slang(8): error 30057: use an assignment operation as predicate expression is not allowed, wrap the assignment with '()' to clarify the intent. + if (a = 0) // error + ^ +tests/diagnostics/assign-in-if.slang(8): warning 30081: implicit conversion from 'int' to 'bool' is not recommended + if (a = 0) // error + ^ +tests/diagnostics/assign-in-if.slang(10): warning 30081: implicit conversion from 'int' to 'bool' is not recommended + if ((a = 0)) // ok. + ^ +} +standard output = { +} -- cgit v1.2.3