From 39522159c245e32a99cfdc47f03236f7028f5c61 Mon Sep 17 00:00:00 2001
From: Yong He <yonghe@outlook.com>
Date: Mon, 26 Feb 2024 17:00:31 -0800
Subject: Allow default values for `extern` symbols. (#3632)

* Allow default values for `extern` symbols.

* Fix.

* Fix test.
---
 tests/diagnostics/unresolved-symbol.slang     | 18 ++++++++++++++++++
 tests/ir/string-literal-hash-reflection.slang |  5 ++++-
 tests/library/export-test.slang               |  6 +++---
 tests/library/library-test.slang              |  6 +++---
 4 files changed, 28 insertions(+), 7 deletions(-)
 create mode 100644 tests/diagnostics/unresolved-symbol.slang

(limited to 'tests')

diff --git a/tests/diagnostics/unresolved-symbol.slang b/tests/diagnostics/unresolved-symbol.slang
new file mode 100644
index 000000000..d5c8444fc
--- /dev/null
+++ b/tests/diagnostics/unresolved-symbol.slang
@@ -0,0 +1,18 @@
+//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): -target hlsl -entry main -profile cs_6_0
+interface IFoo
+{
+    int doThing();
+}
+
+// CHECK: ([[#@LINE+1]]): error 45001:
+extern struct Foo : IFoo;
+// CHECK: ([[#@LINE+1]]): error 45001:
+extern static const int c;
+
+RWStructuredBuffer<int> output;
+
+void main()
+{
+    Foo f;
+    output[0] = c + f.doThing();
+}
\ No newline at end of file
diff --git a/tests/ir/string-literal-hash-reflection.slang b/tests/ir/string-literal-hash-reflection.slang
index a0a28876b..44a0f36e9 100644
--- a/tests/ir/string-literal-hash-reflection.slang
+++ b/tests/ir/string-literal-hash-reflection.slang
@@ -1,4 +1,7 @@
-//TEST:REFLECTION:-stage compute -entry computeMain -target hlsl -no-codegen
+//TEST:REFLECTION(filecheck=CHECK):-stage compute -entry computeMain -target hlsl -no-codegen
+
+// CHECK-DAG: "Hello \t\n\0x083 World": -215446506
+// CHECK-DAG: "Try another": 900483678
 
 import string_literal_module;
 
diff --git a/tests/library/export-test.slang b/tests/library/export-test.slang
index a85396126..c2bb7810e 100644
--- a/tests/library/export-test.slang
+++ b/tests/library/export-test.slang
@@ -5,12 +5,12 @@
 
 // This didn't work for lib_6_2 when compiling via DXC (!). Even though it's stated elsewhere the feature is available from 6.1
 
-//TEST:COMPILE: tests/library/export-library.slang -profile lib_6_3 -target dxil -o tests/library/export-library.dxil
-//TEST:COMPILE: tests/library/export-test.slang -entry computeMain -profile cs_6_3 -target dxil -r tests/library/export-library.dxil -o tests/library/export-test.dxil 
+//TEST:COMPILE: tests/library/export-library.slang -incomplete-library -profile lib_6_3 -target dxil -o tests/library/export-library.dxil
+//TEST:COMPILE: tests/library/export-test.slang -incomplete-library -entry computeMain -profile cs_6_3 -target dxil -r tests/library/export-library.dxil -o tests/library/export-test.dxil 
 
 // Test the produced kernel.
 
-//TEST:COMPARE_COMPUTE_EX:-slang -compute -profile cs_6_3 -dx12 -use-dxil -shaderobj -Xslang... -r tests/library/export-library.dxil -X.
+//TEST:COMPARE_COMPUTE_EX:-slang -compute -profile cs_6_3 -dx12 -use-dxil -shaderobj -Xslang... -r tests/library/export-library.dxil -incomplete-library -X.
 
 extern int foo(int a);
 
diff --git a/tests/library/library-test.slang b/tests/library/library-test.slang
index 3543ced10..e128b6c7c 100644
--- a/tests/library/library-test.slang
+++ b/tests/library/library-test.slang
@@ -5,12 +5,12 @@
 
 // This didn't work for lib_6_2 when compiling via DXC (!). Even though it's stated elsewhere the feature is available from 6.1
 
-//TEST:COMPILE: tests/library/library.slang -profile lib_6_3 -target dxil -o tests/library/library.dxil
-//TEST:COMPILE: tests/library/library-test.slang -entry computeMain -profile cs_6_3 -target dxil -r tests/library/library.dxil -o tests/library/library-test.dxil 
+//TEST:COMPILE: tests/library/library.slang -incomplete-library -profile lib_6_3 -target dxil -o tests/library/library.dxil
+//TEST:COMPILE: tests/library/library-test.slang -incomplete-library -entry computeMain -profile cs_6_3 -target dxil -r tests/library/library.dxil -o tests/library/library-test.dxil 
 
 // Test the produced kernel.
 
-//TEST:COMPARE_COMPUTE_EX:-slang -compute -profile cs_6_3 -dx12 -use-dxil -shaderobj -Xslang... -r tests/library/library.dxil -X.
+//TEST:COMPARE_COMPUTE_EX:-slang -compute -profile cs_6_3 -dx12 -use-dxil -shaderobj -Xslang... -r tests/library/library.dxil -incomplete-library -X.
 
 extern int foo(int a);
 
-- 
cgit v1.2.3