From 1681bc67fbae57b54b66c5dcfcbf315d1efa831b Mon Sep 17 00:00:00 2001 From: Jay Kwak <82421531+jkwak-work@users.noreply.github.com> Date: Tue, 26 Aug 2025 14:38:57 -0700 Subject: Fail slang-test when VVL printed errors (#8280) fixes https://github.com/shader-slang/slang/issues/8271 This PR does the following, - Fail slang-test when there are VVL error messages. - VVL error for `gfx-unit-test-tool/` were not captured properly by the debug callback. - Set an environment variable, `VK_INSTANCE_LAYERS=VK_LAYER_KHRONOS_validation`, for CI and VisualStudio project setup. - Ignores VVL error about NullHandle is used for the acceleration structure; a fix is at ToT of VVL and not available from release build yet. - Fix VVL error complaining about the varying inputs are not provided for the tests, `gfx-unit-test-tool/linkTimeTypeLayout.internal` and `gfx-unit-test-tool/linkTimeTypeLayoutNested.internal`. --------- Co-authored-by: slangbot Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- tests/expected-failure-github.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/expected-failure-github.txt b/tests/expected-failure-github.txt index d647417f2..fdf7f447f 100644 --- a/tests/expected-failure-github.txt +++ b/tests/expected-failure-github.txt @@ -1,4 +1,3 @@ - tests/cooperative-vector/matrix-mul-bias-mut.slang (vk) tests/cooperative-vector/matrix-mul-bias-packed-mut.slang (vk) tests/cooperative-vector/matrix-mul-bias-packed.slang (vk) @@ -35,3 +34,6 @@ tests/compute/interface-shader-param.slang.5 syn (wgpu) tests/language-feature/shader-params/interface-shader-param-ordinary.slang.4 syn (wgpu) tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables.slang.8 (mtl) tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables-2.slang.3 (mtl) + +# GitHub issue #8289; VVL prints an error incorrectly; it will be resolved with a next VulkanSDK +gfx-unit-test-tool/samplerArrayVulkan.internal -- cgit v1.2.3