From 662f43fff6721c6cd013a8f1b2639c2e29fe6be3 Mon Sep 17 00:00:00 2001 From: Tim Foley Date: Sat, 3 Feb 2018 07:30:54 -0800 Subject: Remove non-IR codegen paths (#398) The basic change is simple: remove support for all code generation paths other than the IR. There is a lot of vestigial code left, but the main logic in `ast-legalize.*` is gone. Doing this breaks a *lot* of tests, for various reasons: - We can no longer guarantee exactly matching DXBC or SPIR-V output after things pass through out IR - Many builtins don't have matching versions defined for GLSL output via IR (even when they had versions defined via the earlier approach that worked with the AST) - A lot of code creates intermediate values of opaque types in the IR, which turn into opaque-type temporaries that aren't allowed (this breaks many GLSL tests, but also some HLSL) I implemented some small fixes for issues that I could get working in the time I had, but most of the above are larger than made sense to fix in this commit. For now I'm disabling the tests that cause problems, but we will need to make a concerted effort to get things working on this new substrate if we are going to make good on our goals. --- tests/rewriter/varying-struct.vert | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'tests/rewriter/varying-struct.vert') diff --git a/tests/rewriter/varying-struct.vert b/tests/rewriter/varying-struct.vert index 74ca8be37..042125b15 100644 --- a/tests/rewriter/varying-struct.vert +++ b/tests/rewriter/varying-struct.vert @@ -1,16 +1,13 @@ #version 450 core -//TEST:COMPARE_GLSL: +//TEST_DISABLED:COMPARE_GLSL:-no-mangle #if defined(__SLANG__) __import varying_struct; -in VS_IN foo; -out VS_OUT bar; - -void main() +VS_OUT main(VS_IN foo) { - bar = doIt(foo); + return doIt(foo); } #else -- cgit v1.2.3