From 0360f81b9741ece65768a65731bd23455a3b7a96 Mon Sep 17 00:00:00 2001 From: Tim Foley Date: Fri, 2 Feb 2018 08:49:04 -0800 Subject: Remove support for the -no-checking flag (#392) * Remove support for the -no-checking flag Fixes #381 Fixes #383 Work on #382 - No longer expose flag through API (`SLANG_COMPILE_FLAG_NO_CHECKING`) and command-line (`-no-checking`) options - Remove all logic in `check.cpp` that was withholding diagnostics (including errors) when the no-checking mode was enabled - Remove `HiddenImplicitCastExpr`, which was only created to support no-checking mode (it represented an implicit cast that our checking through was needed, but couldn't emit because it might be wrong) - Remove logic for storing function bodies as raw token lists when checking is turned off. I'm leaving in the `UnparsedStmt` AST node in case we ever need/want to lazily parse and check function bodies down the line. - Remove a few of the code-generation paths we had to contend with, but keep the comment about them in place. - Remove GLSL-based tests that can't meaningfully work with the new approach. - Fix other tests that used a GLSL baseline so that their GLSL compiles with `-pass-through glslang` instead of invoking `slang` with the `-no-checking` flag. - Remove tests that were explicitly added to test the "rewriter + IR" path, since that is no longer supported. There is more cleanup that can be done here, now that we know that AST-based rewrite and IR will never co-exist, but it is probably easier to deal with that as part of removing the AST-based rewrite path. We've lost some test coverage here, but actually not too much if we consider that we are dropping GLSL input anyway. * Fixup: test runner was mis-counting ignored tests * Fixup: turn on dumping on test failure under Travis * Fixup: enable extensions in Linux build of glslang --- tests/reflection/sample-rate-input.glsl | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 tests/reflection/sample-rate-input.glsl (limited to 'tests/reflection/sample-rate-input.glsl') diff --git a/tests/reflection/sample-rate-input.glsl b/tests/reflection/sample-rate-input.glsl deleted file mode 100644 index b8151aee1..000000000 --- a/tests/reflection/sample-rate-input.glsl +++ /dev/null @@ -1,15 +0,0 @@ -//TEST(smoke):REFLECTION:-profile ps_4_0 -no-checking - -// Check that we report sample-rate entry point input correctly - -uniform texture2D t; -uniform sampler s; - -sample in vec2 uv; - -out vec4 c; - -void main() -{ - c = texture(sampler2D(t,s), uv); -} -- cgit v1.2.3