From bdda8a90cdd44ca822b21233ac988f92d1f20826 Mon Sep 17 00:00:00 2001 From: "Harsh Aggarwal (NVIDIA)" Date: Fri, 1 Aug 2025 14:48:53 +0530 Subject: Fix 7441: CUDA boolean vector layout to use 1-byte elements (#7862) * Fix 7441: CUDA boolean vector layout to use 1-byte elements Boolean vectors (bool1, bool2, bool3, bool4) were incorrectly implemented as integer-based types using 4 bytes per element instead of actual 1-byte boolean elements on CUDA targets. Changes: - Update CUDA prelude to define boolean vectors as structs with bool fields instead of typedef aliases to integer vectors - Implement CUDALayoutRulesImpl::GetVectorLayout to use 1-byte alignment for boolean vectors, matching actual CUDA memory layout behavior - Update make_bool functions to populate struct fields correctly This ensures boolean vectors have the same memory layout as bool[4] arrays: - bool1: 1 byte (was 4 bytes) - bool2: 2 bytes (was 8 bytes) - bool3: 3 bytes (was 12 bytes) - bool4: 4 bytes (was 16 bytes) Fixes memory layout mismatch between Slang reflection API and actual CUDA compilation, achieving 75% memory savings for boolean vector usage. * Fix CI issues - Add and update associated functions and operators * Make boolX same as uchar * Use align construct on struct for boolX * Improve Test case for robust alignment checks * Formatting * Disable selected slangpy tests * add metal check which is slightly different than cuda * Test-1 * Test-2 * Test-3 * Test-4 * ReflectionChange * cleanup and update * _slang_select with plain bool is needed for reverse-loop-checkpoint-test --- tests/reflection/buffer-layout.slang.expected | 44 +++++++++++++-------------- 1 file changed, 22 insertions(+), 22 deletions(-) (limited to 'tests/reflection/buffer-layout.slang.expected') diff --git a/tests/reflection/buffer-layout.slang.expected b/tests/reflection/buffer-layout.slang.expected index 84a3e4b49..d37f94ea6 100644 --- a/tests/reflection/buffer-layout.slang.expected +++ b/tests/reflection/buffer-layout.slang.expected @@ -19,7 +19,7 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 0, "size": 4} + "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0} }, { "name": "a", @@ -33,7 +33,7 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 0, "size": 4} + "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0} }, { "name": "y", @@ -41,11 +41,11 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 4, "size": 4} + "binding": {"kind": "uniform", "offset": 4, "size": 4, "elementStride": 0} } ] }, - "binding": {"kind": "uniform", "offset": 16, "size": 8} + "binding": {"kind": "uniform", "offset": 16, "size": 8, "elementStride": 0} }, { "name": "b", @@ -53,7 +53,7 @@ standard output = { "kind": "scalar", "scalarType": "int32" }, - "binding": {"kind": "uniform", "offset": 24, "size": 4} + "binding": {"kind": "uniform", "offset": 24, "size": 4, "elementStride": 0} }, { "name": "c", @@ -70,7 +70,7 @@ standard output = { }, "uniformStride": 16 }, - "binding": {"kind": "uniform", "offset": 32, "size": 24} + "binding": {"kind": "uniform", "offset": 32, "size": 24, "elementStride": 16} }, { "name": "d", @@ -78,7 +78,7 @@ standard output = { "kind": "scalar", "scalarType": "int32" }, - "binding": {"kind": "uniform", "offset": 56, "size": 4} + "binding": {"kind": "uniform", "offset": 56, "size": 4, "elementStride": 0} } ] }, @@ -96,7 +96,7 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 0, "size": 4} + "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0} }, { "name": "a", @@ -110,7 +110,7 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 0, "size": 4} + "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0} }, { "name": "y", @@ -118,11 +118,11 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 4, "size": 4} + "binding": {"kind": "uniform", "offset": 4, "size": 4, "elementStride": 0} } ] }, - "binding": {"kind": "uniform", "offset": 16, "size": 8} + "binding": {"kind": "uniform", "offset": 16, "size": 8, "elementStride": 0} }, { "name": "b", @@ -130,7 +130,7 @@ standard output = { "kind": "scalar", "scalarType": "int32" }, - "binding": {"kind": "uniform", "offset": 24, "size": 4} + "binding": {"kind": "uniform", "offset": 24, "size": 4, "elementStride": 0} }, { "name": "c", @@ -147,7 +147,7 @@ standard output = { }, "uniformStride": 16 }, - "binding": {"kind": "uniform", "offset": 32, "size": 24} + "binding": {"kind": "uniform", "offset": 32, "size": 24, "elementStride": 16} }, { "name": "d", @@ -155,11 +155,11 @@ standard output = { "kind": "scalar", "scalarType": "int32" }, - "binding": {"kind": "uniform", "offset": 56, "size": 4} + "binding": {"kind": "uniform", "offset": 56, "size": 4, "elementStride": 0} } ] }, - "binding": {"kind": "uniform", "offset": 0, "size": 60} + "binding": {"kind": "uniform", "offset": 0, "size": 60, "elementStride": 0} } } }, @@ -180,7 +180,7 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 0, "size": 4} + "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0} }, { "name": "a", @@ -194,7 +194,7 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 0, "size": 4} + "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0} }, { "name": "y", @@ -202,11 +202,11 @@ standard output = { "kind": "scalar", "scalarType": "float32" }, - "binding": {"kind": "uniform", "offset": 4, "size": 4} + "binding": {"kind": "uniform", "offset": 4, "size": 4, "elementStride": 0} } ] }, - "binding": {"kind": "uniform", "offset": 4, "size": 8} + "binding": {"kind": "uniform", "offset": 4, "size": 8, "elementStride": 0} }, { "name": "b", @@ -214,7 +214,7 @@ standard output = { "kind": "scalar", "scalarType": "int32" }, - "binding": {"kind": "uniform", "offset": 12, "size": 4} + "binding": {"kind": "uniform", "offset": 12, "size": 4, "elementStride": 0} }, { "name": "c", @@ -231,7 +231,7 @@ standard output = { }, "uniformStride": 8 }, - "binding": {"kind": "uniform", "offset": 16, "size": 16} + "binding": {"kind": "uniform", "offset": 16, "size": 16, "elementStride": 8} }, { "name": "d", @@ -239,7 +239,7 @@ standard output = { "kind": "scalar", "scalarType": "int32" }, - "binding": {"kind": "uniform", "offset": 32, "size": 4} + "binding": {"kind": "uniform", "offset": 32, "size": 4, "elementStride": 0} } ] } -- cgit v1.2.3