From bdda8a90cdd44ca822b21233ac988f92d1f20826 Mon Sep 17 00:00:00 2001
From: "Harsh Aggarwal (NVIDIA)" <haaggarwal@nvidia.com>
Date: Fri, 1 Aug 2025 14:48:53 +0530
Subject: Fix 7441: CUDA boolean vector layout to use 1-byte elements (#7862)

* Fix 7441: CUDA boolean vector layout to use 1-byte elements

Boolean vectors (bool1, bool2, bool3, bool4) were incorrectly implemented
as integer-based types using 4 bytes per element instead of actual 1-byte
boolean elements on CUDA targets.

Changes:
- Update CUDA prelude to define boolean vectors as structs with bool fields
  instead of typedef aliases to integer vectors
- Implement CUDALayoutRulesImpl::GetVectorLayout to use 1-byte alignment
  for boolean vectors, matching actual CUDA memory layout behavior
- Update make_bool functions to populate struct fields correctly

This ensures boolean vectors have the same memory layout as bool[4] arrays:
- bool1: 1 byte (was 4 bytes)
- bool2: 2 bytes (was 8 bytes)
- bool3: 3 bytes (was 12 bytes)
- bool4: 4 bytes (was 16 bytes)

Fixes memory layout mismatch between Slang reflection API and actual
CUDA compilation, achieving 75% memory savings for boolean vector usage.

* Fix CI issues -

Add and update associated functions and operators

* Make boolX same as uchar

* Use align construct on struct for boolX

* Improve Test case for robust alignment checks

* Formatting

* Disable selected slangpy tests

* add metal check which is slightly different than cuda

* Test-1

* Test-2

* Test-3

* Test-4

* ReflectionChange

* cleanup and update

* _slang_select with plain bool is needed for reverse-loop-checkpoint-test
---
 tests/reflection/binding-gl.hlsl.expected | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'tests/reflection/binding-gl.hlsl.expected')

diff --git a/tests/reflection/binding-gl.hlsl.expected b/tests/reflection/binding-gl.hlsl.expected
index 67df7c267..7e9a17125 100644
--- a/tests/reflection/binding-gl.hlsl.expected
+++ b/tests/reflection/binding-gl.hlsl.expected
@@ -18,7 +18,7 @@ standard output = {
                                 "kind": "scalar",
                                 "scalarType": "float32"
                             },
-                            "binding": {"kind": "uniform", "offset": 0, "size": 4}
+                            "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0}
                         },
                         {
                             "name": "a",
@@ -31,7 +31,7 @@ standard output = {
                                 },
                                 "uniformStride": 16
                             },
-                            "binding": {"kind": "uniform", "offset": 16, "size": 160}
+                            "binding": {"kind": "uniform", "offset": 16, "size": 160, "elementStride": 16}
                         },
                         {
                             "name": "y",
@@ -39,7 +39,7 @@ standard output = {
                                 "kind": "scalar",
                                 "scalarType": "float32"
                             },
-                            "binding": {"kind": "uniform", "offset": 176, "size": 4}
+                            "binding": {"kind": "uniform", "offset": 176, "size": 4, "elementStride": 0}
                         }
                     ]
                 },
@@ -56,7 +56,7 @@ standard output = {
                                     "kind": "scalar",
                                     "scalarType": "float32"
                                 },
-                                "binding": {"kind": "uniform", "offset": 0, "size": 4}
+                                "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0}
                             },
                             {
                                 "name": "a",
@@ -69,7 +69,7 @@ standard output = {
                                     },
                                     "uniformStride": 16
                                 },
-                                "binding": {"kind": "uniform", "offset": 16, "size": 160}
+                                "binding": {"kind": "uniform", "offset": 16, "size": 160, "elementStride": 16}
                             },
                             {
                                 "name": "y",
@@ -77,11 +77,11 @@ standard output = {
                                     "kind": "scalar",
                                     "scalarType": "float32"
                                 },
-                                "binding": {"kind": "uniform", "offset": 176, "size": 4}
+                                "binding": {"kind": "uniform", "offset": 176, "size": 4, "elementStride": 0}
                             }
                         ]
                     },
-                    "binding": {"kind": "uniform", "offset": 0, "size": 192}
+                    "binding": {"kind": "uniform", "offset": 0, "size": 192, "elementStride": 0}
                 }
             }
         },
-- 
cgit v1.2.3